Refactor/center remaining capacity formatting#33
Open
Bhuwan-web wants to merge 4 commits intomoest-np:mainfrom
Open
Refactor/center remaining capacity formatting#33Bhuwan-web wants to merge 4 commits intomoest-np:mainfrom
Bhuwan-web wants to merge 4 commits intomoest-np:mainfrom
Conversation
Bhuwan-web
changed the title
Bhuwan-web
changed the title
|
It's a good step but it would be better if there was issue created before the PR so that contributors could discussion about it. Making things more transparent and organized. Otherwise, we would end up with either conflicts or duplication that will require more manual work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring Code Base to isolate utility functions and output Remaining seats data in more structured format
This PR Deals with better organizing utility function to utils.py that isolates utility functions from main functions.
Also, Works around representing remaining seats of centers in better format along with the center name and center code