General improvements: CI tests, safety parity, docs sync - #70
Merged
Conversation
Restore the missing CI test workflow for web/desktop/C suites, fix stale /stor0800 paths in the flight manual, sync README/ROADMAP with shipped Favorites/NFC/Sub-GHz features, wire the USB auto-check setting to the status poll, and make on-device safety matching honor flexible whitespace like safety-rules.json. Also centralize NFC/Sub-GHz paths and stop tracking host-test binaries. Co-authored-by: Muhammad Rafiq <mohabbis@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
General hygiene and correctness pass after the Sub-GHz / NFC work landed.
.github/workflows/test.ymlso web (vitest), desktop helper (jest), and Flipper host C tests actually run on push/PR (claimed in test: add CI test job and cover key untested modules #61 but the workflow never landed)./stor0800/flipdeck/paths with the real/ext/apps_data/flipdeck/.delay_msvs open profile-level default (Delay configuration per profile #42).auto_detect_usbnow gates the status poll instead of being a no-op toggle.profile_manager_is_value_safematches flexible whitespace likesafety-rules.json(rm -rf,dd\tif=,| bash, etc.), with new host tests.paths.h/ web + desktoppaths.ts; serial installer usesPATHSinstead of hardcoded strings.src/tests/host/.gitignoreand remove committed binaries.Test plan
make -C src/tests/host run— all host suites green (incl. new whitespace/pipe cases)cd web && npm test— 76 passedcd desktop_helper && npm test— 54 passedTestsworkflow runs on this PR