Fix potential integer overflow in buffer growth logic - #2
Closed
mohammidharaz wants to merge 1 commit into
Closed
Conversation
Add SIZE_MAX guard before doubling buffer sizes in yaml_string_extend, yaml_stack_extend, and yaml_queue_extend. Prevents overflow during realloc size calculation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch hardens buffer growth logic in yaml_string_extend,
yaml_stack_extend, and yaml_queue_extend by adding a SIZE_MAX guard
before doubling allocation sizes.
Without this check, integer overflow could occur when calculating
the new buffer size, potentially resulting in incorrect memory
allocation and memory corruption.
The patch preserves existing behavior while preventing overflow
during realloc size calculations.