-
Notifications
You must be signed in to change notification settings - Fork 8
fix: make startup and cross-layer retrieval answer-ready #566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
af2f334
fix: make startup and cross-layer retrieval answer-ready
mohanagy feef714
fix: stabilize strict MCP activation and retrieval
mohanagy 7e681b2
fix: preserve qualified retrieval anchors
mohanagy b42a140
fix: restore stable retrieval quality gates
mohanagy 8d6edce
fix: keep Go route retrieval framework-neutral
mohanagy 4e4e26f
fix: address strict retrieval review findings
mohanagy 18009bc
test: cover obligation recovery telemetry
mohanagy f1030bb
fix: preserve context-pack evidence boundaries
mohanagy 674549c
fix: bound refresh waits and claim support
mohanagy 41fe1bb
fix: serialize Codex config updates
mohanagy b69f338
test: require retained compact claim evidence
mohanagy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 changes: 38 additions & 0 deletions
38
docs/benchmarks/2026-07-17-openstatus-activation/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| # 2026-07-17 — OpenStatus activation acceptance | ||
|
|
||
| This folder records a packed-artifact acceptance run against [`openstatusHQ/openstatus`](https://github.com/openstatusHQ/openstatus) for issues [#564](https://github.com/mohanagy/madar/issues/564) and [#565](https://github.com/mohanagy/madar/issues/565). | ||
|
|
||
| The run used the exact cross-layer question that previously made an agent call Madar repeatedly and then fall back to broad repository discovery. It exercised `madar serve --stdio --auto-refresh` from an unchanged detached OpenStatus worktree and sent the first `context_pack` request immediately after MCP initialization. | ||
|
|
||
| ## Result | ||
|
|
||
| - MCP initialization: **586 ms** | ||
| - First graph-backed response: **3,893 ms** | ||
| - Agent-visible Madar requests: **1** | ||
| - Raw repository fallback operations: **0** | ||
| - Startup rebuild: **no** | ||
| - Serialized response: **1,666 / 1,800 tokens** | ||
| - Evidence: **high / strong / complete / ready** | ||
| - Agent directive: **`answer_from_pack`** | ||
| - Broad-search fallback: **`not_needed`** | ||
| - Selected-file precision: **7/7 relevant unique files (100%)** | ||
| - Unrelated UI files: **0** | ||
|
|
||
| The selected evidence covers the Go checker, workflow incident/notification handling, incident schema, tRPC status computation, and the divergent Connect-RPC status computation. The receipt contains only upstream-relative paths and aggregate graph metadata; it does not contain the external checkout path or source bodies. | ||
|
|
||
| ## Artifact and repository | ||
|
|
||
| - Madar artifact: local `npm pack` of `@lubab/madar@0.31.3` | ||
| - Tarball SHA-256: `ea71918c1e74fd7b73609f3054d2f90619f117d9d41bbb57cc167bfca525a645` | ||
| - OpenStatus commit: `295e5a72f52c172d326aa950e81043e72a4f20c0` | ||
| - OpenStatus worktree state: clean | ||
| - Graph: 10,496 nodes, 21,437 edges, 24,446,369 bytes | ||
| - Indexing: 2,443 indexed, 0 failed, 73 policy-skipped, 85 unsupported | ||
|
|
||
| ## Exact prompt | ||
|
|
||
| > Trace how a failed monitor check becomes an incident, triggers notifications, and affects the public status-page status in this repository. Cite the exact files and symbols involved, identify any inconsistent status-computation paths, and clearly state any remaining uncertainty. This is read-only; do not change files. | ||
|
|
||
| ## Interpretation boundary | ||
|
|
||
| This is implementation acceptance for retrieval and startup behavior, not a release or universal benchmark claim. The issue requires three consecutive Claude trials, three consecutive Codex trials, and human semantic comparison with the direct-search answer before a release claim. Those model trials remain pending and are recorded as such in the JSON receipt. |
122 changes: 122 additions & 0 deletions
122
docs/benchmarks/2026-07-17-openstatus-activation/receipt.share-safe.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,122 @@ | ||
| { | ||
| "schema_version": 1, | ||
| "generated_at": "2026-07-17T08:45:30Z", | ||
| "status": "implementation_acceptance", | ||
| "release_claim_eligible": false, | ||
| "prompt": "Trace how a failed monitor check becomes an incident, triggers notifications, and affects the public status-page status in this repository. Cite the exact files and symbols involved, identify any inconsistent status-computation paths, and clearly state any remaining uncertainty. This is read-only; do not change files.", | ||
| "artifact": { | ||
| "source": "npm_pack", | ||
| "package": "@lubab/madar", | ||
| "version": "0.31.3", | ||
| "tarball_sha256": "sha256:ea71918c1e74fd7b73609f3054d2f90619f117d9d41bbb57cc167bfca525a645", | ||
| "registry_published": false | ||
| }, | ||
| "external_repository": { | ||
| "url": "https://github.com/openstatusHQ/openstatus", | ||
| "commit": "295e5a72f52c172d326aa950e81043e72a4f20c0", | ||
| "worktree_clean": true | ||
| }, | ||
| "graph": { | ||
| "bytes": 24446369, | ||
| "nodes": 10496, | ||
| "edges": 21437, | ||
| "indexing": { | ||
| "state": "partial", | ||
| "candidates": 2601, | ||
| "indexed": 2443, | ||
| "indexed_with_warnings": 0, | ||
| "skipped_by_policy": 73, | ||
| "unsupported": 85, | ||
| "failed": 0 | ||
| } | ||
| }, | ||
| "startup": { | ||
| "transport": "stdio", | ||
| "auto_refresh": true, | ||
| "mcp_initialization_ms": 586, | ||
| "first_graph_request_ms": 3893, | ||
| "request_count": 1, | ||
| "raw_fallback_count": 0, | ||
| "graph_rebuilt": false, | ||
| "acceptance_threshold_ms": 5000, | ||
| "passed": true | ||
| }, | ||
| "response": { | ||
| "serialized_tokens": 1666, | ||
| "serialized_token_budget": 1800, | ||
| "budget_enforced": true, | ||
| "pack_confidence": "high", | ||
| "evidence_strength": "strong", | ||
| "coverage": "complete", | ||
| "answerability": "ready", | ||
| "agent_directive": "answer_from_pack", | ||
| "broad_search_fallback": "not_needed", | ||
| "discovery_exclusions_total": 15, | ||
| "discovery_exclusions_relevant": 0, | ||
| "indexing_uncertain_total": 158, | ||
| "indexing_uncertain_relevant": 0 | ||
| }, | ||
| "selected_evidence": [ | ||
| { | ||
| "label": "statusPage.ts", | ||
| "source_file": "packages/api/src/router/statusPage.ts", | ||
| "line_number": 1, | ||
| "obligations": ["public_status_computation"] | ||
| }, | ||
| { | ||
| "label": "triggerNotifications()", | ||
| "source_file": "apps/workflows/src/checker/alerting.ts", | ||
| "line_number": 17, | ||
| "obligations": ["notification_dispatch"] | ||
| }, | ||
| { | ||
| "label": "computeEffectiveStatus()", | ||
| "source_file": "packages/api/src/router/effective-status.ts", | ||
| "line_number": 11, | ||
| "obligations": ["inconsistent_status_computation"] | ||
| }, | ||
| { | ||
| "label": "upsertMonitorStatus()", | ||
| "source_file": "apps/workflows/src/checker/alerting.ts", | ||
| "line_number": 276, | ||
| "obligations": ["failure_transport", "incident_state"] | ||
| }, | ||
| { | ||
| "label": "incident.ts", | ||
| "source_file": "packages/db/src/schema/incidents/incident.ts", | ||
| "line_number": 1, | ||
| "obligations": ["incident_state"] | ||
| }, | ||
| { | ||
| "label": "findOpenIncident()", | ||
| "source_file": "apps/workflows/src/checker/index.ts", | ||
| "line_number": 37, | ||
| "obligations": ["incident_state"] | ||
| }, | ||
| { | ||
| "label": "computeOverallStatus()", | ||
| "source_file": "apps/server/src/routes/rpc/handlers/status-page/index.ts", | ||
| "line_number": 360, | ||
| "obligations": ["public_status_computation", "inconsistent_status_computation"] | ||
| }, | ||
| { | ||
| "label": "UpdateStatus()", | ||
| "source_file": "apps/checker/checker/update.go", | ||
| "line_number": 29, | ||
| "obligations": ["failure_transport"] | ||
| } | ||
| ], | ||
| "human_judgment": { | ||
| "selected_nodes": 8, | ||
| "selected_unique_files": 7, | ||
| "relevant_unique_files": 7, | ||
| "selected_file_precision": 1, | ||
| "unrelated_ui_files": 0, | ||
| "all_five_obligations_present": true | ||
| }, | ||
| "pending_release_gates": [ | ||
| "three consecutive Claude trials", | ||
| "three consecutive Codex trials", | ||
| "human semantic comparison of final answers against the direct-search baseline" | ||
| ] | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.