feat: widen pool source to per_entity_per_period facts#53
Merged
mohossam01 merged 1 commit intoMay 14, 2026
Merged
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Register scalar and vectorized dispatch handlers for
pool.<attr>columns on per_entity_per_period fact tables — the most common fact grain, one row per entity per period. Each handler reads the row's entity from context and draws uniformly from its declared pool; the load-time pool-coverage validator widens to admit the new grain. A column likepayment_type: pool.payment_methodnow coexists with SCD2 and CDC on a single transactional fact. Per_period facts, reference dims, and sub-entity dims stay out of scope — those rows have no per-row entity binding.Files Modified
plotsim/tables.pyplotsim/validation.pytests/test_pool_on_fact.pytests/test_pool_attr.pydocs/site/column-types.mddocs/site/feature-reference.mdCHANGELOG.mdHow to test