Skip to content

Combination of many refactoring PR's #2#4

Open
mohsaka wants to merge 5 commits into
tvf_11336from
tvf_12350
Open

Combination of many refactoring PR's #2#4
mohsaka wants to merge 5 commits into
tvf_11336from
tvf_12350

Conversation

@mohsaka
Copy link
Copy Markdown
Owner

@mohsaka mohsaka commented Mar 7, 2025 •
edited
Loading

Combination of refactoring PR's

12350
12407
12476
12531
12813

Description

Motivation and Context

Impact

Test Plan

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* ... 
* ... 

Hive Connector Changes
* ... 
* ...

If release note is NOT required, use:

== NO RELEASE NOTE ==

mohsaka and others added 3 commits March 7, 2025 14:38
@mohsaka @kasiafi
Add builders for table function arguments
fd81ad1 
Changes adapted from trino/PR#12350
Original commit: 998315075343beecef962657b8cbf440d53cc13b
Author: kasiafi

Co-authored-by: kasiafi <30203062+kasiafi@users.noreply.github.com>
@mohsaka @kasiafi
Refactor table function analysis
1f6e841 
Changes adapted from trino/PR#12407
Original commit: 712b8e98ff8a726f95295ac539159fc532628273
Original commit: 131dc44af97b31a2fa8115028d98d06671641bfa
Author: kasiafi

Co-authored-by: kasiafi <30203062+kasiafi@users.noreply.github.com>
@mohsaka @kasiafi
Add argument-less builder methods for boolean values
ae3fde1 
Changes adapted from trino/PR#12476
Original commit: 0da095e14b0855f89af3c4f254a5a60280fc7170
Author: kasiafi

Co-authored-by: kasiafi <30203062+kasiafi@users.noreply.github.com>
mohsaka and others added 2 commits March 7, 2025 15:40
@mohsaka @kasiafi
Refactor ConnectorTableFunction into interface
3a6dada 
Changes adapted from trino/PR#12531
Original commit: 18bb60262cb0850cf839c2b20b434344921f5122
Original commit: 4a7d72afb64f93a9748a4c6b4defc2d42bbae000
Author: kasiafi

Co-authored-by: kasiafi <30203062+kasiafi@users.noreply.github.com>
@mohsaka @kasiafi
Remove unused argument from TableArgumentSpecification.java builder.
8342f70 
Changes adapted from trino/PR#12813
Original commit: 5310671f80291394b12ba2ea746e4e60051aaff4
Author: kasiafi

Co-authored-by: kasiafi <30203062+kasiafi@users.noreply.github.com>
@mohsaka mohsaka changed the title Add builders for table function arguments #2 Combination of many refactoring PR's #2 Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mohsaka