Implement table function source#6

[xin-zhang2]

Description

Motivation and Context

Impact

Test Plan

Contributor checklist

• Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
• PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
• Documented new properties (with its default value), SQL syntax, functions, or other functionality.
• If release notes are required, they follow the release notes guidelines.
• Adequate tests were added if applicable.
• CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* ... 
* ... 

Hive Connector Changes
* ... 
* ... 

If release note is NOT required, use:

== NO RELEASE NOTE ==

[mohsaka]

Currently on updating the TableFunctionMatcher for commit
05535286323470132dd5df0e88ee1e6aa49f4c34
There is an interesting situation with Symbol <-> VariableReferenceExpression that occurs

Expected Trino Output from here

                Set<Reference> expectedPassThrough = expectedTableArgument.passThroughVariables().stream()
                        .map(symbolAliases::get)
                        .collect(toImmutableSet());
                Set<Reference> actualPassThrough = argumentProperties.passThroughSpecification().columns().stream()
                        .map(PassThroughColumn::symbol)
                        .map(Symbol::toSymbolReference)
                        .collect(toImmutableSet());

expectedPassThrough = {SingletonImmutableSet@11437}  size = 1
 0 = {Reference@11479} "field::smallint"
  type = {SmallintType@11481} "smallint"
  name = "field"
actualPassThrough = {SingletonImmutableSet@11438}  size = 1
 0 = {Reference@11485} "field::smallint"
  type = {SmallintType@11481} "smallint"
  name = "field"

It seems like SymbolReference in Trino is == VariableReferenceExpression.

[mohsaka]

Currently bringing in the last commit. Working on the ImplementTableFunctionSource file. Quite a large one. Feel free to pick it up if you fix the testing.

[mohsaka]

For one of the usages, we are able to use coalesce as we are passing in VariableReferenceExpressions. The others do not and are forms of Expressions.

I looked into SpecialFormExpressions but those require VariableReferenceExpressions as well.

Also attempted to bring in rowExpression from QueryPlanner/RelationPlanner, however we are missing a few of the objects required. They would need to be passed in from PlanOptimizers. But could not find a shared class between them to pass them all the way through.

[mohsaka]

Current issue

Mismatch on ordering Type.

variable = {VariableReferenceExpression@6868} "d"
 name = "d"
 type = {UnknownType@6877} "unknown"
 sourceLocation = {Optional@5524} "Optional.empty"
that.variable = {VariableReferenceExpression@6874} "d"
 name = "d"
 type = {BigintType@6883} "bigint"
 sourceLocation = {Optional@5524} "Optional.empty"

Symbol Alias differences

Trino LATEST

symbolAliases = {SymbolAliases@10219} "SymbolAliases{{c=c::bigint, d=d::bigint}}"
 map = {RegularImmutableMap@10234}  size = 2
  "c" -> {Reference@10240} "c::bigint"
   key = "c"
    value = {byte[1]@10245} [99]
    coder = 0
    hash = 99
    hashIsZero = false
   value = {Reference@10240} "c::bigint"
    type = {BigintType@10246} "bigint"
     signature = {TypeSignature@10248} "bigint"
     javaType = {Class@10249} "long"
     valueBlockType = {Class@8145} "class io.trino.spi.block.LongArrayBlock"
    name = "c"
     value = {byte[1]@10245} [99]
     coder = 0
     hash = 99
     hashIsZero = false
  "d" -> {Reference@10241} "d::bigint"
   key = "d"
    value = {byte[1]@10131} [100]
    coder = 0
    hash = 100
    hashIsZero = false
   value = {Reference@10241} "d::bigint"
    type = {BigintType@10246} "bigint"
    name = "d"

Presto

symbolAliases = {SymbolAliases@5520} "SymbolAliases{{c="c", d="d"}}"
map = {RegularImmutableMap@6892}  size = 2
 "c" -> {SymbolReference@6938} ""c""
  key = "c"
  value = {SymbolReference@6938} ""c""
   name = "c"
    value = {char[1]@6946} [c]
    hash = 99
   location = {Optional@5524} "Optional.empty"
    value = null
 "d" -> {SymbolReference@6939} ""d""
  key = "d"
   value = {char[1]@6945} [d]
   hash = 100
  value = {SymbolReference@6939} ""d""
   name = "d"
    value = {char[1]@6945} [d]
    hash = 100
   location = {Optional@5524} "Optional.empty"
    value = null

Remembered Xin hit a similar issue. Found function matchSpecification and changed his custom function to this as well.