Skip to content

RF+BF: Move reporting code to own subpackage, break up big modules - #15

Open
moloney wants to merge 1 commit into
mainfrom
enh-reports
Open

RF+BF: Move reporting code to own subpackage, break up big modules#15
moloney wants to merge 1 commit into
mainfrom
enh-reports

Conversation

@moloney

@moloney moloney commented May 19, 2023

Copy link
Copy Markdown
Owner

Few fixes/improvements around reporting. In particular stop raising exceptions in the setter for the done propety.

Few fixes/improvements around reporting. In particular stop raising
exceptions in the setter for the done propety.
@codecov-commenter

codecov-commenter commented May 19, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 79.57% and project coverage change: -1.89 ⚠️

Comparison is base (b3f4e4c) 77.71% compared to head (39a9b9a) 75.82%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
- Coverage   77.71%   75.82%   -1.89%     
==========================================
  Files          25       24       -1     
  Lines        6407     5667     -740     
==========================================
- Hits         4979     4297     -682     
+ Misses       1428     1370      -58     
Impacted Files Coverage Δ
dcm/reports/net_report.py 64.75% <64.75%> (ø)
dcm/reports/xfer_report.py 70.61% <70.61%> (ø)
dcm/store/base.py 70.78% <70.78%> (ø)
dcm/util.py 80.71% <78.94%> (+3.57%) ⬆️
dcm/lazyset.py 83.22% <84.00%> (+38.85%) ⬆️
dcm/router.py 87.54% <87.54%> (ø)
dcm/net.py 91.55% <88.78%> (+8.52%) ⬆️
dcm/cli.py 72.97% <89.28%> (+1.73%) ⬆️
dcm/reports/__init__.py 68.77% <92.68%> (ø)
dcm/node.py 95.83% <95.83%> (ø)
... and 12 more

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants