fix: resolve author mapping for posts and comments#25
Open
IISweetHeartII wants to merge 3 commits intomoltbook:mainfrom
Open
fix: resolve author mapping for posts and comments#25IISweetHeartII wants to merge 3 commits intomoltbook:mainfrom
IISweetHeartII wants to merge 3 commits intomoltbook:mainfrom
Conversation
- Add author info (name, display_name) to post creation response - Add author info to comment creation response - Fetch author details via JOIN after INSERT - Fixes issue moltbook#15 (all posts showing author: null) - Fixes issue moltbook#19 (author attribution missing) Previously, POST /posts and POST /comments would return records without author information because the RETURNING clause only included basic fields. Now we perform a secondary query to JOIN with the agents table and return complete author details.
This was referenced Feb 1, 2026
- Allow unauthenticated access to read-only endpoints - GET /posts, /posts/:id, /posts/:id/comments now use optionalAuth - GET /comments/:id, /submolts, /submolts/:name, etc. now use optionalAuth - GET /agents/profile, /search now use optionalAuth - Write endpoints (POST/PATCH/DELETE) still require authentication - Fixes issue moltbook#16 (auth works for read/post but fails on upvote/comment) - Related to issue moltbook#18 (POST operations failing) This makes the API consistent with typical social platforms where reading content is public but actions require authentication.
- Log all errors to console (even in production) for debugging - Handle PostgreSQL constraint violations (23xxx codes) - Provide more detailed error information in logs - Related to issue moltbook#18 (better diagnostics for post creation failures)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes critical bugs where posts and comments were being created without author information, leading to
author: nullin API responses.Changes
PostService.js
create()method to fetch author details after INSERTauthor_nameandauthor_display_nameCommentService.js
create()method to fetch author details after INSERTauthor_nameandauthor_display_nameIssues Fixed
author: null, profile/post pages return 404/Bot Not FoundRoot Cause
The
INSERT ... RETURNINGstatements only returned basic fields likeid,title,content, etc., but did not include author information. Theagentstable was never joined, so API responses contained no author attribution.Testing
After this change:
POST /api/v1/postsreturns posts WITH author info (author_name,author_display_name)POST /api/v1/posts/:id/commentsreturns comments WITH author infoNotes
Issues #16 and #18 (401 errors on write endpoints) appear to be environment/deployment-specific and are not addressed in this PR. The code inspection shows proper auth middleware is applied to all routes. These may require server-side investigation (CORS, proxy, rate limiting, etc.).