Repository navigation
chore(release): v0.2.6 — adopt core sasso 0.6.2 (compressed color fix) - #1
Merged
Merged
Conversation
Recompile-only bump; the gem's Ruby API is unchanged. Picks up the upstream fix where compressed output emits the shortest equivalent legacy-color form, matching dart-sass 1.101.0: - darken(#336699, 10%) -> hsl(210,50%,30%) (was rgb(38.25,76.5,114.75)) - hsl(210, 50%, 40%) -> #369 Expanded output is unchanged. Pins ext/sasso/Cargo.toml to sasso =0.6.2 and adds a binding-level regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adopt core sasso 0.6.2 (recompile-only; the gem's Ruby API is unchanged).
Core 0.6.2 fixes compressed output to emit the shortest equivalent legacy-color
form, matching dart-sass 1.101.0 byte-for-byte:
darken(#336699, 10%)rgb(38.25,76.5,114.75)hsl(210,50%,30%)hsl(210, 50%, 40%)hsl(210,50%,40%)#369Expanded output is unchanged. This matters for embedders that compile
user-authored CSS at runtime (e.g.
darken/lighten/mixin custom CSS) — theoutput is now identical to dart-sass.
Changes
ext/sasso/Cargo.toml: pinsasso_core=0.6.1→=0.6.2(+Cargo.lock).lib/sasso/version.rb: gem0.2.5→0.2.6.CHANGELOG.md:[0.2.6]entry.test/compile_test.rb: binding-level regression test for the new compressedcolor output.
Validation
rake compilebuilds the native ext against the freshly-published core 0.6.2.rake test: 17 runs, 38 assertions, 0 failures.Sasso.compile_string("a{x:darken(#336699,10%)}", style: :compressed)→a{x:hsl(210,50%,30%)}.Upstream: momiji-rs/sasso#14 (core fix, released as crate 0.6.2).