update onsenui to 2.12.10 and ngx-onsenui to 7.1.1 - #22
Draft
takuyaW wants to merge 1 commit into
Draft
Conversation
Moves off the 2.11.2 line now that the Angular binding works with current onsenui again. onsenui 2.12.10 restores the named exports its ESM entry needs, and ngx-onsenui 7.1.1 widens its onsenui peer to ^2.12.10. Draft: onsenui 2.12.10 / ngx-onsenui 7.1.1 are not published yet, so www/ has not been rebuilt. After both are on npm, run `npm install && npm run build` to regenerate www/ and mark this ready.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the Onsen UI dependencies so this Angular template can move off the old 2.11.2 line.
onsenui2.11.22.12.10ngx-onsenui^7.0.0^7.1.1Why it was stuck on 2.11.2
ngx-onsenui's fesm bundle uses named imports fromonsenui(
import { PageLoader, _internal, notification, platform } from 'onsenui'). The onsenui ESM entry stopped exposing those named exports once themodulefield was added in 2.12.0, so the names resolved toundefinedand Angular broke at runtime. On top of that,ngx-onsenui's exact-pinnedonsenuipeer made every onsenui bump fail withERESOLVE.Both are addressed upstream:
^2.12.10and releases as 7.1.1 (chore(ngx): widen onsenui peer to ~2.12.10 and release 7.1.1 OnsenUI/OnsenUI#3099).onsenui@2.12.10andngx-onsenui@7.1.1are not published yet, sonpm installwill fail andwww/has not been rebuilt. This PR currently changes onlypackage.json.After both packages are on npm:
then commit the rebuilt
www/and mark this PR ready for review.