v1.2.0: self-nomination (#41) + batch user lookup (#33 follow-up) - #60
Merged
Conversation
- #41 Members can request a feedback round on themselves (My Feedback → Request feedback): they pick reviewers, and the round is created as a draft owned by a manager (their team admin, else a global admin) — NEVER the subject — so the requester can never de-anonymize their reviewers. One open request at a time; the owner reviews and starts it. Owner≠subject is asserted in tests and verified end-to-end (subject can't see raw submissions of their own request). - Non-admin Rounds now also lists rounds you own, so a team admin can see and manage rounds they created (fixes a pre-existing gap; also surfaces self-nominated rounds to the team-admin owner). - #33 follow-up: paginated round lists resolve only the current page's users via Users.FindByIDs (ANY($1::uuid[]), gateway-tested) instead of a full-table load. gosec 0 / govulncheck 0; full suite incl. Postgres gateway green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#41 — Self-nomination
Members can now request a 360 round on themselves from My Feedback → Request feedback. They pick their reviewers; the round is created as a draft owned by a manager (their team admin, else a global admin) — never the subject. This is the load-bearing design point: if the requester owned the round they'd gain raw-submission access and could de-anonymize reviewers, so ownership always goes to someone else. The owner reviews and starts it. One open request at a time.
Verified end-to-end: the subject viewing their own requested round does not see the raw-submissions section; a test asserts
CreatedByID != SubjectID.Supporting change
Non-admin Rounds now also lists rounds you own — fixing a pre-existing gap where a team admin couldn't see rounds they created, and surfacing self-nominated rounds to the team-admin owner so they can approve them.
#33 follow-up (perf)
Paginated round lists now resolve only the users referenced on the current page via
Users.FindByIDs(ANY($1::uuid[]), gateway-tested), instead of loading the whole user table on every page — closing the review follow-up from v1.1.0.Verification
go build/vet/gofmt/go test ./...(incl. Postgres gateway) green ·gosec0 ·govulncheck0 · release image builds and serves/request-feedback. CHANGELOG[1.2.0], sonar bumped.