serialization: remove container wrappers and serialize directly#9077
Merged
luigi1111 merged 2 commits intomonero-project:masterfrom Jan 18, 2024
Merged
serialization: remove container wrappers and serialize directly#9077luigi1111 merged 2 commits intomonero-project:masterfrom
luigi1111 merged 2 commits intomonero-project:masterfrom
Conversation
jeffro256
force-pushed
the
ser_containers_no_wrapper
branch
2 times, most recently
from
79b26d5 to
ad7fe71
Compare
jeffro256
force-pushed
the
ser_containers_no_wrapper
branch
from
ad7fe71 to
ae77f83
Compare
vtnerd
reviewed
Nov 28, 2023
Some downstream code (most notably PR UkoeHB#25) wants to use the src/serialization lib for storing information persistently. When one builds classes/machines wishing to serialize containers, they must use the `serializable_*` container classes. In this case, this makes the Seraphis library code unnecessarily tightly coupled with the src/serialization code since one cannot swap out their type of storage format without major refactoring of class field types. By serializing STL containers directly, we can abstract the serialization details away, making for much cleaner design. Also small bonus side effect of this change is that STL containers with custom Comparators, Allocators, and Hashers are serializable. `std::multimap` is added to the list of serializable containers. Depends upon monero-project#9069.
jeffro256
force-pushed
the
ser_containers_no_wrapper
branch
from
ae77f83 to
2525200
Compare
vtnerd
approved these changes
Nov 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some downstream code (most notably PR UkoeHB#25) wants to use the src/serialization lib
for storing information persistently. When one builds classes/machines wishing to serialize containers, they must use
the
serializable_*container classes. In this case, this makes the Seraphis library code unnecessarily tightly coupledwith the src/serialization code since one cannot swap out their type of storage format without major refactoring of class
field types. By serializing STL containers directly, we can abstract the serialization details away, making for much
cleaner design. Also small bonus side effect of this change is that STL containers with custom Comparators, Allocators,
and Hashers are serializable.
Depends upon #9069.