feat(compass-collection): Create Preview and Doc Count Screen – CLOUDP-381907#7847
Merged
feat(compass-collection): Create Preview and Doc Count Screen – CLOUDP-381907#7847
Conversation
jcobis
changed the title
mabaasit
approved these changes
Mar 6, 2026
| data-testid="document-count-input" | ||
| /> | ||
| <div> | ||
| <Body className={estimatedDiskSizeLabelStyles}> |
Collaborator
There was a problem hiding this comment.
You can use the weight prop on Body component.
| import { generateDocument } from './script-generation-utils'; | ||
| import { validateDocumentCount } from './utils'; | ||
|
|
||
| const FAKER_FUNCTIONS_URL = 'https://fakerjs.dev/api/'; |
Collaborator
There was a problem hiding this comment.
We are using this at other places as well, maybe we refactor it?
Collaborator
Author
There was a problem hiding this comment.
Good suggestion, done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Document count input and preview screen
Raw schema confirmation screen drive-by
Drive-by: In the confirmation screen, ensure the sample values setting banner below the schema view remains visible without scrolling for large schemas. Fixed by making the schema view scrollable with a max height.
Checklist
Motivation and Context
Types of changes