Draft
Conversation
kraenhansen
force-pushed
the
kh/multiline-dots-and-prompts
branch
from
fc6fe8b to
f1f6d57
Compare
gagik
approved these changes
Oct 7, 2024
addaleax
reviewed
Oct 7, 2024
| .substring(outputOffsetBefore, outputOffsetAfterDots) | ||
| .trim(); | ||
| // Expect just the multiline dots | ||
| expect(output.startsWith('... ...')).equals( |
Collaborator
There was a problem hiding this comment.
This test does fail for me, locally, but unfortunately I think that's actually expected behavior? The first prompt printed by mongosh in response to the .writeInputLine() call is a regular prompt, not a multiline prompt, but that's happening because the first line of the writeInputLine() argument is empty/whitespace-only.
That being said ... yeah, there's a good chance that that causes the flakiness in the FLE test at least. I feel like it's probably a good idea to just always .trim() the input to .writeInputLine()? For raw input, there's always .writeInput() itself
Contributor
Author
There was a problem hiding this comment.
Great catch! Trimming the input to writeInputLine fixed the issue 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For now this PR adds a failing test demonstrating how writing a multiline command prints an extraneous prompt before multiline dots (the "..." prefixed after every line-break in the input).
Arguably not a huge bug, but I do believe it's the reason for this comment:
mongosh/packages/e2e-tests/test/test-shell.ts
Line 193 in d3e2935
And the systematic failure on #2171