-
Notifications
You must be signed in to change notification settings - Fork 12
chore(deps): bump actions/cache from 5 to 6 #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dependabot
wants to merge
1
commit into
main
Choose a base branch
from
dependabot/github_actions/actions/cache-6
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Semgrep identified an issue in your code:
actions/cache@v6uses a mutable tag, so ifv6is repointed, this workflow can execute attacker-controlled code during CI.More details about this
Cache zstd buildpullsactions/cacheusing the mutable ref@v6, not a specific commit. If thev6tag is ever moved to a different commit, this workflow will run that new code duringhost_tests, beforenpm run install-zstd,npm install, andnpm test.A plausible attack looks like this:
actions/cacherepository and repoints thev6tag to it.push,pull_request, orworkflow_dispatchand reachesuses: actions/cache@v6in theCache zstd buildstep.actions/cachebecause the workflow trusts@v6.path: depsandkey: zstd-deps-${{ runner.os }}-${{ runner.arch }}-${{ hashFiles(...) }}, and use the job's token or other available secrets to send repository data to an external server.This is a supply-chain risk in the exact
uses: actions/cache@v6line because the workflow follows a tag that can be silently changed later.To resolve this comment:
✨ Commit fix suggestion
actions/cache@v6with a full 40-character commit SHA for the exactactions/cacherelease you want to use.uses: actions/cache@<full-40-char-sha> # v6.x.x.actions/cacherelease you intend to trust, and make sure it is the commit for that release tag rather than a branch or short tag. Pinning to a commit SHA prevents the action owner from silently changing what runs under the same tag.usesvalue for this step; the existingwith:settings such aspath:andkey:can stay as they are.Alternatively, if you need to confirm the correct pinned revision before editing, look up the
actions/cacherelease page and copy the full commit SHA associated with thev6release you want to keep using.💬 Ignore this finding
Reply with Semgrep commands to ignore this finding.
/fp <comment>for false positive/ar <comment>for acceptable risk/other <comment>for all other reasonsAlternatively, triage in Semgrep AppSec Platform to ignore the finding created by github-actions-mutable-action-tag.
🛟 Help? Slack #semgrep-help or go/semgrep-help.
Resolution Options:
/fp $reason(if security gap doesn’t exist)/ar $reason(if gap is valid but intentional; add mitigations/monitoring)/other $reason(e.g., test-only)You can view more details about this finding in the Semgrep AppSec Platform.