PHPLIB-1834: Send afterClusterTime on writes in causally-consistent sessions#1932
Closed
GromNaN wants to merge 3 commits into
Closed
PHPLIB-1834: Send afterClusterTime on writes in causally-consistent sessions#1932GromNaN wants to merge 3 commits into
GromNaN wants to merge 3 commits into
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Member
Author
|
This implementation requires libmongoc to expose "afterClusterTime" in command events for causally consistent sessions. Without this, the driver cannot materialize the field in command monitoring events, making the assertions in these tests impossible to satisfy. The tests have been marked with to skip them until libmongoc supports this feature. Closing this PR until the required libmongoc changes are available. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing