Repository navigation
Cover legacy decoding and fix private decoder delegation - #57
Merged
Merged
Conversation
Exercise both adapters and fix the plain-driver instance decoder calling a private class method with an explicit receiver. Permit local coverage runs with the current Rails dependency files. Combined real adapter coverage improves from 95.95% to 99.32%; the remaining line selects an older Rack constant. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dblock
force-pushed
the
dblock/coverage
branch
from
October 17, 2026 12:09
28f08ea to
68fb222
Compare
Danger ReportNo issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit baseline: default main Coveralls 95.95% (6 missed lines). Add regressions for both adapters decoding raw Marshal strings and BSON binary values, nil payloads, and the standalone version entry point. The uncovered plain-driver instance helper incorrectly called a private class method with an explicit receiver; delegate with send so the existing helper actually works.
Combined full adapter runs on Rails 7.2: 99.32% line coverage (146/147), with no excluded source lines or narrowed tracked files. The remaining line selects the legacy Rack session-options constant. Allow COVERAGE=true in the current Rails Gemfile for reproducible local measurements. Existing Ruby4 coverage still combines both real suites.
Accepted CI coverage: 99.32% (146/147 relevant lines), Coveralls build 82425052.
Prepared by an AI on behalf of @dblock.