Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/tagpr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,3 @@ jobs:
id: tagpr
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ As a library, implement the `Callback` interface and call `Parse` on a `Parser`.
```go
cb := &MyParserImpl{}
parser := &followparser.Parser{
WorkDir: "/var/tmp", // where pos files are stored
WorkDir: "/path/to/workdir", // where pos files are stored
Callback: cb,
// optional:
// ArchiveDir: "/var/log/archive",
Expand Down
20 changes: 14 additions & 6 deletions fpos.go
Original file line number Diff line number Diff line change
Expand Up @@ -77,21 +77,29 @@ func (pf *posFile) write(pos int64, fstat *fStat) error {
Inode: fstat.Inode,
Dev: fstat.Dev,
}
file, err := os.Create(pf.filename)
jb, err := json.Marshal(fp)
if err != nil {
return err
}
defer file.Close()
jb, err := json.Marshal(fp)
// To avoid race condition, we create a temporary file and then rename it to the target filename.
f, err := os.CreateTemp(filepath.Dir(pf.filename), filepath.Base(pf.filename))
if err != nil {
return err
}
_, err = file.Write(jb)
defer f.Close()
_, err = f.Write(jb)
if err != nil {
return err
}
return file.Sync()

err = f.Sync()
if err != nil {
return err
}
err = f.Close()
if err != nil {
return err
}
return os.Rename(f.Name(), pf.filename)
}

func fileStat(filename string) (*fStat, error) {
Expand Down
4 changes: 2 additions & 2 deletions go.mod
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
module github.com/kazeburo/followparser
module github.com/monitoring-forge/followparser

go 1.23.4
go 1.25

require github.com/avast/retry-go/v4 v4.7.0
Loading