CopyTo and AppendTo

[kazeburo]

PR Type

Enhancement, Tests

---

Description

• Adds point counting and transfer operations

• Validates nil sources and destinations

• Adds comprehensive operation coverage

---

Diagram Walkthrough

flowchart LR
  Sampdo["Sampdo instance"] -- "Count points" --> Count["Point count"]
  Sampdo -- "Copy points" --> Slice["Destination slice"]
  Sampdo -- "Append points" --> Destination["Destination Sampdo"]
  Tests["Operation tests"] --> Sampdo

Loading

File Walkthrough

	Relevant files
Enhancement	stats.go Add point counting and transfer methods                                    stats.go Adds Count for retrieving stored point counts. Adds CopyTo for appending points to slices. Adds AppendTo for transferring points between instances. Returns errors for nil sources or destinations. +31/-0
Tests	stats_test.go Test counting and point transfer operations                            stats_test.go Tests counts before and after sorting. Verifies copying into empty and existing slices. Covers nil destination error handling. Verifies append operations and sum preservation. +91/-0

---

[github-actions]

Benchmark Comparison

Base: main
PR: feat/copy-append-to

BenchmarkSampdoAll results

goos: linux
goarch: amd64
pkg: github.com/monitoring-forge/sampdo
cpu: AMD EPYC 9V74 80-Core Processor                
                                        │ base-bench.txt │            pr-bench.txt             │
                                        │     sec/op     │    sec/op     vs base               │
SampdoAll/sampdo/100000/duplicates-4         921.7µ ± 5%   920.3µ ± 12%       ~ (p=0.218 n=10)
SampdoAll/sampdo/100000/random-4             1.852m ± 1%   1.684m ±  1%  -9.06% (p=0.001 n=10)
SampdoAll/sampdo/100000/wide-4               1.891m ± 1%   1.872m ±  8%       ~ (p=0.315 n=10)
SampdoAll/sampdo/100000/sorted-4             191.1µ ± 1%   192.6µ ±  1%       ~ (p=0.052 n=10)
SampdoAll/sampdo/100000/response_time-4      1.624m ± 1%   1.626m ±  1%       ~ (p=0.912 n=10)
geomean                                      1.000m        980.9µ        -1.94%

                                        │ base-bench.txt │             pr-bench.txt              │
                                        │      B/op      │     B/op      vs base                 │
SampdoAll/sampdo/100000/duplicates-4        1.532Mi ± 0%   1.532Mi ± 0%       ~ (p=0.099 n=10)
SampdoAll/sampdo/100000/random-4            1.532Mi ± 0%   1.532Mi ± 0%  -0.00% (p=0.004 n=10)
SampdoAll/sampdo/100000/wide-4              1.532Mi ± 0%   1.532Mi ± 0%       ~ (p=0.102 n=10)
SampdoAll/sampdo/100000/sorted-4            785.1Ki ± 0%   785.1Ki ± 0%       ~ (p=1.000 n=10) ¹
SampdoAll/sampdo/100000/response_time-4     1.532Mi ± 0%   1.532Mi ± 0%  +0.00% (p=0.033 n=10)
geomean                                     1.334Mi        1.334Mi       -0.00%
¹ all samples are equal

                                        │ base-bench.txt │            pr-bench.txt             │
                                        │   allocs/op    │ allocs/op   vs base                 │
SampdoAll/sampdo/100000/duplicates-4          5.000 ± 0%   5.000 ± 0%       ~ (p=1.000 n=10) ¹
SampdoAll/sampdo/100000/random-4              5.000 ± 0%   5.000 ± 0%       ~ (p=1.000 n=10) ¹
SampdoAll/sampdo/100000/wide-4                5.000 ± 0%   5.000 ± 0%       ~ (p=1.000 n=10) ¹
SampdoAll/sampdo/100000/sorted-4              4.000 ± 0%   4.000 ± 0%       ~ (p=1.000 n=10) ¹
SampdoAll/sampdo/100000/response_time-4       5.000 ± 0%   5.000 ± 0%       ~ (p=1.000 n=10) ¹
geomean                                       4.782        4.782       +0.00%
¹ all samples are equal

[github-actions]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 PR contains tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Nil Receiver Panic The new methods dereference t without checking whether the source receiver is nil. Calling Count or CopyTo on a nil *Sampdo panics, unlike the nearby Sorted method which returns an error for a nil receiver. AppendTo has the same issue and should validate the source before accessing t.points. func (t *Sampdo) Count() int { return len(t.points) } // CopyTo copies all points from the current Sampdo instance to the provided destination slice. func (t *Sampdo) CopyTo(dst *[]float64) error { if dst == nil || *dst == nil { return fmt.Errorf("destination slice is nil") } *dst = append(*dst, t.points...)

[github-actions]

Standalone PR Review

PR-Agent could not safely update the persistent review. This standalone result will not replace the canonical review.

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 PR contains tests

🔒 No security concerns identified

⚡ No major issues detected

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Standalone PR Review

PR-Agent could not safely update the persistent review. This standalone result will not replace the canonical review.

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 PR contains tests

🔒 No security concerns identified

⚡ No major issues detected

[github-actions]

Standalone PR Review

PR-Agent could not safely update the persistent review. This standalone result will not replace the canonical review.

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 PR contains tests

🔒 No security concerns identified

⚡ No major issues detected

[github-actions]

PR Code Suggestions ✨

No code suggestions found for the PR.

[github-actions]

PR Code Suggestions ✨

No code suggestions found for the PR.