Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes the JSON struct field tags from several schema files in order to clean up the Go structures and avoid unused metadata.
- Removed JSON tags from protocol, peer, hello, entry, and event schema structures.
- Updated inline tags in resolver structures to use only YAML annotations.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| internal/network/net/schema/protocol.go | Removed JSON tags from Header, Preamble, and Frame |
| internal/network/net/schema/peer.go | Removed JSON tags from PeerMetadata fields |
| internal/network/net/schema/hello.go | Removed JSON tags from ClientHello, ServerHello, and ClientHelloAck |
| internal/network/net/schema/entry.go | Removed JSON tag from EntryHeader field |
| internal/event/event.go | Removed JSON tags (and omitempty options) from event structures |
| internal/commander/resolver/resolver.go | Removed JSON inline tags from embedded schema types |
Comments suppressed due to low confidence (2)
internal/event/event.go:137
- Removing the 'omitempty' option from the Error field may lead to unintended JSON serialization behavior if nil errors need to be omitted. Verify that this change matches the intended API design and serialization logic.
Error error
internal/commander/resolver/resolver.go:13
- The removal of the JSON inline tag from the embedded PeerMetadata may affect JSON serialization if it is in use. Confirm that YAML is the only intended serialization format for this structure.
schema.PeerMetadata `yaml:",inline"`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #74.