Skip to content

PSS: Fixes VFS workers to close root on error #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iamandrii merged 1 commit into from
Jun 9, 2025
Merged

PSS: Fixes VFS workers to close root on error #94

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions internal/pss/vfs_workers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,11 @@ func (v *vfsReadFile) execute(ctx context.Context, p *pss, timeout time.Duration
commandCtx, cancel := context.WithTimeout(ctx, timeout)
defer cancel()

file, err := p.vfs.Root(vent.VMRead).OpenAt(commandCtx, v.filePath)
root := p.vfs.Root(vent.VMRead)
Comment thread
iamandrii marked this conversation as resolved.

file, err := root.OpenAt(commandCtx, v.filePath)
if err != nil {
_ = root.CloseCtx(commandCtx)
return err
}
p.logger.Debug("file opened successfully", "path", v.filePath)
Expand Down Expand Up @@ -195,8 +198,11 @@ func (v *vfsAddFile) execute(ctx context.Context, p *pss, timeout time.Duration)
commandCtx, cancel := context.WithTimeout(ctx, timeout)
defer cancel()

dir, err := p.vfs.Root(vent.VMWrite).OpenAt(commandCtx, v.path)
root := p.vfs.Root(vent.VMWrite)
Comment thread
iamandrii marked this conversation as resolved.

dir, err := root.OpenAt(commandCtx, v.path)
if err != nil {
_ = root.CloseCtx(commandCtx)
p.logger.Error("failed to open dir", "path", v.path, "err", err)
return err
}
Expand Down