Added event hook system and basic events - #11
Open
Santa3ta wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an event hooking system with predefined events, useful for people to create mods without having to look at the actual game code or create their own harmony patches.
Will add more events to hook in future if approved
One concern I have with my approach is this will significantly increase the number of patches in the Core/Patches folder. Not sure if you would prefer me to create a subfolder of Patches that the hooks use
May modify the hook system to be more granular in future e.g something like
EventService.Subscribe(HookId.PlayerTookDamage, modes: {"Campaign","EndlessSuperstructure"}, modifiers: {"default", "Ironknuckle"})