ngx_md5.c from nginx#15
Open
pavel-ignatovich wants to merge 1 commit intomasterfrom
Open
Conversation
![monocodus[bot]](https://avatars.githubusercontent.com/in/28526?s=60&v=4){kind=small}
|
|
||
| #define SET(n) \ | ||
| (block[n] = \ | ||
| (uint32_t) p[n * 4] | \ |
There was a problem hiding this comment.
Suggested change
| (uint32_t) p[n * 4] | \ | |
| (uint32_t) p[(n) * 4] | \ |
This comment was generated with the following checker: ClangTidy
| #define SET(n) \ | ||
| (block[n] = \ | ||
| (uint32_t) p[n * 4] | \ | ||
| ((uint32_t) p[n * 4 + 1] << 8) | \ |
There was a problem hiding this comment.
Suggested change
| ((uint32_t) p[n * 4 + 1] << 8) | \ | |
| ((uint32_t) p[(n) * 4 + 1] << 8) | \ |
This comment was generated with the following checker: ClangTidy
| (block[n] = \ | ||
| (uint32_t) p[n * 4] | \ | ||
| ((uint32_t) p[n * 4 + 1] << 8) | \ | ||
| ((uint32_t) p[n * 4 + 2] << 16) | \ |
There was a problem hiding this comment.
Suggested change
| ((uint32_t) p[n * 4 + 2] << 16) | \ | |
| ((uint32_t) p[(n) * 4 + 2] << 16) | \ |
This comment was generated with the following checker: ClangTidy
| (uint32_t) p[n * 4] | \ | ||
| ((uint32_t) p[n * 4 + 1] << 8) | \ | ||
| ((uint32_t) p[n * 4 + 2] << 16) | \ | ||
| ((uint32_t) p[n * 4 + 3] << 24)) |
There was a problem hiding this comment.
Suggested change
| ((uint32_t) p[n * 4 + 3] << 24)) | |
| ((uint32_t) p[(n) * 4 + 3] << 24)) |
This comment was generated with the following checker: ClangTidy
| */ | ||
|
|
||
| static const u_char * | ||
| ngx_md5_body(ngx_md5_t *ctx, const u_char *data, size_t size) |
There was a problem hiding this comment.
The function is too long
ngx_md5_body( ngx_md5_t * ctx , const u_char * data , size_t size) now spans 92 lines.
Corresponding modifications started here.
Keep your functions' length within 50 lines to improve readability.
This comment was generated with the following checker: long_method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/core/ngx_md5.c from https://github.com/nginx/nginx/blob/c60b61a/src/core/ngx_md5.c