test_client.py from kubernetes-client#24
Conversation
![monocodus[bot]](https://avatars.githubusercontent.com/in/28526?s=60&v=4){kind=small}
| } | ||
| } | ||
|
|
||
| class TestClient(unittest.TestCase): |
There was a problem hiding this comment.
| class TestClient(unittest.TestCase): | |
| class TestClient(unittest.TestCase): |
This comment was generated with the following checker: AutoPEP8
| '-c', | ||
| 'for i in $(seq 1 3); do date; done'] | ||
| resp = stream(api.connect_get_namespaced_pod_exec, name, 'default', | ||
| command=exec_command, |
There was a problem hiding this comment.
| command=exec_command, | |
| command=exec_command, |
This comment was generated with the following checker: AutoPEP8
| 'for i in $(seq 1 3); do date; done'] | ||
| resp = stream(api.connect_get_namespaced_pod_exec, name, 'default', | ||
| command=exec_command, | ||
| stderr=False, stdin=False, |
There was a problem hiding this comment.
| stderr=False, stdin=False, | |
| stderr=False, stdin=False, |
This comment was generated with the following checker: AutoPEP8
| resp = stream(api.connect_get_namespaced_pod_exec, name, 'default', | ||
| command=exec_command, | ||
| stderr=False, stdin=False, | ||
| stdout=True, tty=False) |
There was a problem hiding this comment.
| stdout=True, tty=False) | |
| stdout=True, tty=False) |
This comment was generated with the following checker: AutoPEP8
|
|
||
| exec_command = 'uptime' | ||
| resp = stream(api.connect_post_namespaced_pod_exec, name, 'default', | ||
| command=exec_command, |
There was a problem hiding this comment.
| command=exec_command, | |
| command=exec_command, |
This comment was generated with the following checker: AutoPEP8
| for command, value in commands_expected_values: | ||
| client = stream(api.connect_get_namespaced_pod_exec, name, 'default', | ||
| command=command, | ||
| stderr=True, stdin=False, |
There was a problem hiding this comment.
| stderr=True, stdin=False, | |
| stderr=True, stdin=False, |
This comment was generated with the following checker: AutoPEP8
| client = stream(api.connect_get_namespaced_pod_exec, name, 'default', | ||
| command=command, | ||
| stderr=True, stdin=False, | ||
| stdout=True, tty=False, |
There was a problem hiding this comment.
| stdout=True, tty=False, | |
| stdout=True, tty=False, |
This comment was generated with the following checker: AutoPEP8
| command=command, | ||
| stderr=True, stdin=False, | ||
| stdout=True, tty=False, | ||
| _preload_content=False) |
There was a problem hiding this comment.
| _preload_content=False) | |
| _preload_content=False) |
This comment was generated with the following checker: AutoPEP8
| def setUpClass(cls): | ||
| cls.config = base.get_e2e_configuration() | ||
|
|
||
| def test_pod_apis(self): |
There was a problem hiding this comment.
The function is too long
test_pod_apis( self ) now spans 57 lines.
Corresponding modifications started here.
Keep your functions' length within 50 lines to improve readability.
This comment was generated with the following checker: long_method
| break | ||
| time.sleep(1) | ||
|
|
||
| commands_expected_values = ( |
There was a problem hiding this comment.
The variable name is too long
Variable name commands_expected_values is now 24 characters long.
Keep length of your variable names within 20 characters to improve readability.
This comment was generated with the following checker: naming_analysis
1 participant
kubernetes/e2e_test/test_client.py from https://github.com/kubernetes-client/python/blob/02232a2/kubernetes/e2e_test/test_client.py