Skip to content

PrintableNewAnonClassNode.php from PHP-Parser#26

Open
pavel-ignatovich wants to merge 1 commit intomasterfrom
php_parser_printablenode.php
Open

PrintableNewAnonClassNode.php from PHP-Parser#26
pavel-ignatovich wants to merge 1 commit intomasterfrom
php_parser_printablenode.php

Conversation

@pavel-ignatovich
Copy link
Copy Markdown

Copy link
Copy Markdown

@monocodus monocodus Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is autogenerated code-style review, new suggestions: 3

public $stmts;

public function __construct(
array $args, Node\Name $extends = null, array $implements, array $stmts, array $attributes
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
array $args, Node\Name $extends = null, array $implements, array $stmts, array $attributes
array $args,
Node\Name $extends = null,
array $implements,
array $stmts,
array $attributes

This comment was generated with the following checker: PHP-CS-Fixer

// We don't assert that $class->name is null here, to allow consumers to assign unique names
// to anonymous classes for their own purposes. We simplify ignore the name here.
return new self(
$newNode->args, $class->extends, $class->implements,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$newNode->args, $class->extends, $class->implements,
$newNode->args,

This comment was generated with the following checker: PHP-CS-Fixer

// to anonymous classes for their own purposes. We simplify ignore the name here.
return new self(
$newNode->args, $class->extends, $class->implements,
$class->stmts, $newNode->getAttributes()
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$class->stmts, $newNode->getAttributes()
$class->extends,
$class->implements,
$class->stmts,
$newNode->getAttributes()

This comment was generated with the following checker: PHP-CS-Fixer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant