Skip to content

Revert "Collector Fixes"#44

Merged
patryk-przybysz merged 1 commit into
develfrom
revert-34-agent/collector-fixes
Jun 22, 2026
Merged

Revert "Collector Fixes"#44
patryk-przybysz merged 1 commit into
develfrom
revert-34-agent/collector-fixes

Conversation

@patryk-przybysz

Copy link
Copy Markdown
Collaborator

Reverts #34

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts the prior “Collector Fixes” change set (#34), restoring earlier collector behavior for RAPL (CPU package power) and NVML (GPU metrics) and simplifying timestamp generation in several collectors.

Changes:

  • Replaces the RAPL collector’s sysfs powercap-based implementation with an MSR-based implementation.
  • Refactors the NVML collector from multi-GPU enumeration to a single GPU (index 0) handle/id.
  • Changes several collectors’ timestamps from explicit duration_cast to time_since_epoch().count().

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 12 comments.

Show a summary per file
File Description
sources/agent/src/collectors/rapl_collector.h Removes prior zone-based powercap state; introduces MSR constants/state.
sources/agent/src/collectors/rapl_collector.cc Replaces powercap discovery/sampling with MSR reads for RAPL energy.
sources/agent/src/collectors/ram_collector.cc Simplifies timestamp creation in RAM metrics.
sources/agent/src/collectors/proc_stat_collector.cc Simplifies timestamp creation in CPU utilization metrics.
sources/agent/src/collectors/nvml_collector.h Switches from per-device storage to single-handle/single-id fields.
sources/agent/src/collectors/nvml_collector.cc Switches from multi-GPU enumeration/loop to only GPU 0 sampling; simplifies timestamp creation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread sources/agent/src/collectors/rapl_collector.h
Comment thread sources/agent/src/collectors/rapl_collector.h
Comment thread sources/agent/src/collectors/rapl_collector.cc
Comment thread sources/agent/src/collectors/rapl_collector.cc
Comment thread sources/agent/src/collectors/rapl_collector.cc
Comment thread sources/agent/src/collectors/ram_collector.cc
Comment thread sources/agent/src/collectors/proc_stat_collector.cc
Comment thread sources/agent/src/collectors/nvml_collector.cc
Comment thread sources/agent/src/collectors/nvml_collector.cc
Comment thread sources/agent/src/collectors/nvml_collector.h

@varev-dev varev-dev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@patryk-przybysz patryk-przybysz merged commit 158bf58 into devel Jun 22, 2026
2 checks passed
@patryk-przybysz patryk-przybysz deleted the revert-34-agent/collector-fixes branch June 22, 2026 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants