fix(docs): S-DOCS3-FIX page embed attrs 재로딩 시 유실 (parseHTML round-trip)#248
Merged
AngryJay91 merged 1 commit intomainfrom Apr 15, 2026
Merged
Conversation
…d-trip) **RC:** addAttributes에 per-attribute parseHTML 미지정 → markdown 형식 doc에서 turndown의 pageEmbed rule이 data-doc-id 만 보존하고 legacy docid attr은 제거. 재로딩 시 Tiptap 기본 parseHTML이 docid를 못 찾아 null → picker 초기 상태 복귀. **수정:** - addAttributes에 per-attribute parseHTML + renderHTML 추가 - parseHTML: data-doc-id (markdown 경로) || docid (HTML 경로 하위호환) fallback - renderHTML: 각 attr을 data-* HTML 속성으로 일관 직렬화 - 노드 레벨 renderHTML 단순화: HTMLAttributes에 data-page-embed 만 merge (per-attr renderHTML이 이미 data-doc-id 등 세팅) **테스트 보강:** 15 → 25케이스 - parseHTML round-trip describe 신설 (10케이스) - markdown 경로 (data-doc-id only): docId/title/icon/slug 전원 복원 검증 - HTML 경로 (legacy docid attr): 하위호환 검증 - attr 누락 시 null 반환 검증 - full round-trip 통합 케이스 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RC
addAttributes에 per-attributeparseHTML미지정 → markdown 형식 doc에서 turndown의pageEmbedrule이data-doc-id만 보존하고docidattr은 제거. 재로딩 시 Tiptap 기본parseHTML이docid를 못 찾아null→ picker 초기 상태 복귀.HTML 형식 doc은
docidattr이 raw HTML에 보존되어 정상 작동. markdown 형식 doc만 영향받는 경로.변경 내용
addAttributesper-attributeparseHTML+renderHTML추가parseHTML:data-doc-id(markdown 경로)||docid(HTML 경로 하위호환) fallbackrenderHTML: 각 attr을data-*HTML 속성으로 일관 직렬화renderHTML단순화 (data-page-embed추가만 담당)AC 체크리스트
addAttributesper-attrparseHTML—data-doc-id/docidfallbackaddAttributesper-attrrenderHTML—data-doc-id등 data-* 일관 직렬화renderHTML단순화pnpm vitest run: 25/25 passpnpm type-check: FULL TURBO🤖 Generated with Claude Code