Skip to content

fix: defer provider user stream event #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
moose-lab merged 1 commit into from
May 30, 2026
Merged

fix: defer provider user stream event #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/core/__tests__/api-session-runtime.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ test("runProviderSessionTurn executes API mode without a Local CLI process", asy
);
assert.deepEqual(
events.map((event) => event.type),
["message", "status", "text_delta", "message", "turn_end", "status"],
["status", "message", "text_delta", "message", "turn_end", "status"],
);
});

Expand Down Expand Up @@ -193,6 +193,6 @@ test("runProviderSessionTurn removes the pending user message after the session
);
assert.deepEqual(
events.map((event) => event.type),
["message", "status"],
["status"],
);
});
3 changes: 2 additions & 1 deletion src/core/api-session-runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,6 @@ export async function runProviderSessionTurn({
const insertedUser = db.prepare(
"INSERT INTO session_messages (session_id, role, content) VALUES (?, 'user', ?)",
).run(sessionId, message);
emit(sessionId, { type: "message", role: "user", content: message });

db.prepare("UPDATE sessions SET status = 'running' WHERE id = ?").run(
sessionId,
Expand All @@ -116,6 +115,8 @@ export async function runProviderSessionTurn({
};
}

emit(sessionId, { type: "message", role: "user", content: message });

if (!result.ok) {
db.prepare(
"UPDATE sessions SET status = 'failed', ended_at = datetime('now') WHERE id = ?",
Expand Down
Loading