feat: update filter to allow multiple RGB values to be configured for a single instance of the filter#4
Open
thaMANSTA wants to merge 1 commit into
Conversation
thaMANSTA
commented
Mar 31, 2025
- I've been playing a bunch of PS1 lightgun games, and capturing using OBS on an M1 Mac Mini
- adding multiple instances of the filter to filter the different flash colours is cumbersome
- for Lethal Enforcers 1, "tint" the scene red when you get hit, causing secondary flashing in addition to the white flashes when you shoot
- to get around this, I was taking screenshots of "flashing" frames, and adding multiple filters for all the shades of red that were flashing on screen
- unfortunately, adding many flash filters causes FPS issues
- solution is to update the filter to support multiple RGB values for the same filter instance, which should be much more performant than multiple filter instances
… a single instance of the filter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.