Skip to content

Add default allowlist patterns for read-only operations #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
basre-velocity wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add default allowlist patterns for read-only operations #464

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/renderer/src/stores/useSettingsStore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,13 @@ const DEFAULT_SETTINGS: AppSettings = {
updateChannel: 'stable',
initialSetupComplete: false,
commandFilter: {
allowlist: ['edit: **', 'write: **'],
allowlist: [
'edit: **',
'write: **',
'read: **',
Comment thread
greptile-apps[bot] marked this conversation as resolved.

@chatgpt-codex-connector chatgpt-codex-connector Bot May 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep sensitive files out of read allowlist

When a user enables the command filter with the default ask behavior, this new broad read: ** allowlist entry auto-approves reads of every path, but the default blocklist only covers edit: and write: secrets such as .env, *.key, and credentials*. Since CommandFilterService.formatCommandString() emits reads as read: <path> and blocklist checks only help when a matching read: block exists, a request like read: /workspace/project/.env is silently allowed instead of prompting; add matching sensitive-file blocks for read (and any read-like defaults such as grep if intended) or narrow this default.

Useful? React with 馃憤聽/ 馃憥.

'grep: ** in **',
'glob: **'
],
blocklist: [
'bash: rm -rf *',
'bash: sudo rm *',
Expand Down