bolt: implement tx_add_output message codec

[harsh04044]

Implements the tx_add_output codec (type 67) for BOLT 2 interactive-tx.

The script field is a variable-length scriptPubKey, length-prefixed via the WireFormat trait. Tests cover roundtrip, empty script, trailing bytes, and truncation at each field boundary.

Part of #5.

[kushagra0902]

The PR looks good to me with everything handled properly

[Vineet1101]

The PR looks good to me with everything handled properly

bro how can you say that. I am trying to run it locally and my code is not even compiling

The implementation for TxAddOutput imports bitcoin::ScriptBuf, but the rust-bitcoin crate isn't actually a dependency in smite's workspace.

[harsh04044]

The PR looks good to me with everything handled properly

bro how can you say that. I am trying to run it locally and my code is not even compiling The implementation for TxAddOutput imports bitcoin::ScriptBuf, but the rust-bitcoin crate isn't actually a dependency in smite's workspace.

Good catch. The bitcoin crate was added as part of the tx_add_input PR (#23) which hasn't merged yet. Added it directly to this branch -- should compile now.
@Vineet1101

[kushagra0902]

The PR looks good to me with everything handled properly

bro how can you say that. I am trying to run it locally and my code is not even compiling The implementation for TxAddOutput imports bitcoin::ScriptBuf, but the rust-bitcoin crate isn't actually a dependency in smite's workspace.

Good catch. The bitcoin crate was added as part of the tx_add_input PR (#23) which hasn't merged yet. Added it directly to this branch -- should compile now. @Vineet1101

I was working at something else and had the package already that bypassed the error, good catch @Vineet1101

[harsh04044]

Done, script is now Vec, added the assert on script.len() in encode(), and split out truncation tests for the script length and script data fields.
@morehouse

[morehouse]

CI is failing

[morehouse]

Needs a rebase to merge.