Add BOLT channel_reestablish (type 136) codec support

[theAnuragMishra]

This PR adds support for the BOLT 2 channel_reestablish message, which is needed for reconnect/state resynchronization flows.

I have run the tests and it's all green.

part of #5

[ekzyis]

Hello and welcome! Thank you for the PR.

Noticed two things:

1. Trailing bytes should be decoded as a TLV stream

2. CI didn't run yet, but it would fail. You can run the commands locally before requesting the next review, see .github/workflows/rust.yml.

Related to this, I think we should add #[allow(clippy::too_many_lines)] to fn message_type_values():

$ cargo clippy --all-targets --all-features -- -D warnings
...
error: this function has too many lines (112/100)
   --> smite/src/bolt.rs:671:5
    |
671 |     fn message_type_values() {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_lines
    = note: `-D clippy::too-many-lines` implied by `-D clippy::pedantic`
    = help: to override `-D clippy::pedantic` add `#[allow(clippy::too_many_lines)]`

error: could not compile `smite` (lib test) due to 1 previous error

diff --git a/smite/src/bolt.rs b/smite/src/bolt.rs
index c261a1d..b7e2aa9 100644
--- a/smite/src/bolt.rs
+++ b/smite/src/bolt.rs
@@ -668,6 +668,7 @@ mod tests {
     }

     #[test]
+    #[allow(clippy::too_many_lines)]
     fn message_type_values() {
         assert_eq!(
             Message::Warning(Warning::all_channels("")).msg_type(),

[ekzyis]

TLV stream missing

[Chand-ra]

Related to this, I think we should add #[allow(clippy::too_many_lines)] to fn message_type_values():

$ cargo clippy --all-targets --all-features -- -D warnings
...
error: this function has too many lines (112/100)
   --> smite/src/bolt.rs:671:5
    |
671 |     fn message_type_values() {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_lines
    = note: `-D clippy::too-many-lines` implied by `-D clippy::pedantic`
    = help: to override `-D clippy::pedantic` add `#[allow(clippy::too_many_lines)]`

error: could not compile `smite` (lib test) due to 1 previous error

diff --git a/smite/src/bolt.rs b/smite/src/bolt.rs
index c261a1d..b7e2aa9 100644
--- a/smite/src/bolt.rs
+++ b/smite/src/bolt.rs
@@ -668,6 +668,7 @@ mod tests {
     }

     #[test]
+    #[allow(clippy::too_many_lines)]
     fn message_type_values() {
         assert_eq!(
             Message::Warning(Warning::all_channels("")).msg_type(),

I do that here in PR #38. I thought of creating a separate PR for it but it seemed like a related change.

[theAnuragMishra]

Thank you so much for the review guys. Addressing everything in some time

[theAnuragMishra]

I have addressed all of your points @ekzyis and @Chand-ra . Thank you so much for your reviews.
in short:
added TLVStream support, moved the constant to types.rs, and picked a per_commitment_point value from lightning/bolt bolt 3 Appendix E.

Also ran all the checks in the ci locally, everything is clean.

[ekzyis]

Please look at how tlvs is implemented and tested in other messages, for example open_channel2.