Ignore startup exits in JVM crash handler#88
Open
morehouse wants to merge 4 commits into
Open
Conversation
The presence of the marker file indicates that startup of the target is complete and that fuzzing is about to begin. This will be used by the JVM crash handler to filter out exits that occur during Eclair startup.
Eclair runs various commands as subprocesses during node startup that are expected to call exit(0). We don't want to generate crash reports for those.
The flag was added to prevent a false-positive error report when starting Eclair and is no longer needed now that we use a marker file to detect once startup is complete.
Now that we filter out exits during node startup, we don't need to have a hacky java wrapper to limit the scope of our crash handler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Eclair starts up it runs several commands as subprocesses, some of which call
exitand trigger our crash handler.Previously we resorted to a couple hacks to filter out these startup exits:
-no-version-checkto the Eclair startup script to avoidjava --versiontriggering our crash handlerThis worked for a while, but when I recently updated my machine the crash handler started reporting a startup exit again.
This PR removes the ad-hoc filtering methods in favor of a more robust mechanism: ignore all exits until startup is complete. This is accomplished by using a marker file to signal to the crash handler whether startup has completed or not.