smite-ir: implement BuildNodeAnnouncement operation#89
Open
morehouse wants to merge 1 commit into
Open
Conversation
Enables programs that build signed node_announcement messages and send them to the target. The rgb_color and alias fields are fixed-length literal params instead of Bytes variables so that they are always the correct size. This means we lose the ability to cross-pollinate these two fields with other messages, but since these fields serve a purely cosmetic purpose the tradeoff is good.
morehouse
force-pushed
the
build_node_announcement
branch
from
6040b22 to
e4cf372
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables programs that build signed
node_announcementmessages and send them to the target.The
rgb_colorandaliasfields are fixed-length literal params instead ofBytesvariables so that they are always the correct size. This means we lose the ability to cross-pollinate these two fields with other messages, but since these fields serve a purely cosmetic purpose the tradeoff is good.Ref: #71