Skip to content

Report approved command launch failures accurately - #157

Merged
morgaesis merged 9 commits into
mainfrom
fix/command-launch-outcomes
Sep 10, 2026
Merged

morgaesis merged 9 commits into
mainfrom
fix/command-launch-outcomes

test: avoid logging complete execution outcomes

fe6e29e
Select commit
Loading
Failed to load commit list.
postil-dev / postil/review failed Sep 10, 2026 in 36s

1 error, 1 warn, 0 info

warn review incomplete · info 1 advisory finding open

info 1 suppressed
  • Release registered ownership when spawn fails at src/server/runtime.rs:780: cites a line the named construct does not sit on; severity warn, confidence 0.94. prepare registers a state whose pending_launch flag remains true until adopt runs. If the subsequent spawn fails, the state is still held by the cleanup worker, cleanup_tick never considers it complete, and any secret_files lease remains retained indefinitely. Make failed launch handling clear the pending state and release the lease, or unregister the state before propagating the spawn error.

Review details