Feature/cluster key secret#119
Draft
markus-mnm wants to merge 1 commit into
Draft
Conversation
Owner
|
@markus-mnm can you pls resolve conflicts + are you tested it? is it realy works? |
Author
|
I tested it fairly thoroughly a few weeks back, but don't have access to my work setup anymore, but I'll set up a new local test environment and move it out of draft once I tested it with the latest changes from main. |
Owner
|
@markus-mnm pls resolve conflicts |
- Add wazuh.keyExistingSecret parameter - Make secret-cluster-key generation conditional - Allow using external secrets from Vault/ExternalSecrets operator - Use to_be_replaced_by_hostname and to_be_replaced_by_cluster_key as supported by wazuh-docker
markus-mnm
force-pushed
the
feature/cluster-key-secret
branch
from
cf2014f to
2cb3b84
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a further step to remove secrets from the chart values.
For the cluster key, I found that this can be done by using an existing "to_be_replaced_by_cluster_key" placeholder which the manager init files replace.
https://github.com/wazuh/wazuh-docker/blob/c893d86b4a3dff604832cbe1e9b1c760edcb4b59/build-docker-images/wazuh-manager/config/etc/cont-init.d/0-wazuh-init#L161
See issue #80