feat(completion): Implement completion commands#3
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request implements shell completion support for the morpherctl CLI tool, enabling users to generate completion scripts for bash, zsh, fish, and powershell shells.
- Adds a new
completioncommand with argument validation and usage instructions - Implements completion script generation logic with support for four major shells
- Includes comprehensive unit tests for the completion functionality
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| cmd/completion/completion.go | Defines the completion command with usage examples and shell validation |
| internal/completion/completion.go | Implements core completion generation logic and supported shells listing |
| internal/completion/completion_test.go | Provides unit tests for completion generation and shell support validation |
| cmd/root.go | Integrates the completion command into the root CLI command structure |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds shell completion support to the
morpherctlCLI, allowing users to easily generate completion scripts for bash, zsh, fish, and powershell. The changes include a newcompletioncommand, supporting logic for script generation, and corresponding tests to ensure correctness.Shell completion feature:
completionsubcommand tomorpherctlthat generates shell completion scripts for bash, zsh, fish, and powershell, with usage instructions and argument validation incmd/completion/completion.go.completioncommand into the root command by importing and registering it incmd/root.go. [1] [2]Completion logic and testing:
internal/completion/completion.go.internal/completion/completion_test.go.