[GSoC 2026] M2.17 - Fix part of #24717: Wire certificate assessment result page and My Certificates tab to backend data by mosin74 · Pull Request #3 · mosin74/oppia

mosin74 · 2026-08-13T11:30:53Z

Overview

This PR fixes part of [Feature Request]: Learner certificates oppia/oppia#24717.
This PR does the following:

Certificate Assessment Result page
- certificate-assessment-result-card.component.ts: replaced the hard-coded mock result with a real getCertificateAssessmentResultAsync(attemptId) call; maps attempt data into a per-topic breakdown (topic name, % score, correct/related question counts); raises the passing threshold from 70% to 80% (pass is derived from total_score since the backend exposes no pass/fail flag); onRetryAssessment() now navigates back into the assessment flow (/certificate-assessment/{certificateId}).
- certificate-assessment-result-card.component.html/.css: added the titled background banner to the page, hides the time-taken row when time_taken_in_minutes is null (e.g. unfinished attempts), and adjusted card layout/styling.
- certificate-assessment-result-page.module.ts: imports the new shared banner module.
Player page navigation
- certificate-assessment-player-page.component.ts: submitAssessment() now routes to /certificate-assessment-result/{attemptId} (was /certificate-assessment/{certId}/result/{attemptId}).
My Certificates tab (Learner Dashboard)
- my-certificates-tab.component.ts: replaced stub attempts with real getCertificateAssessmentAttemptsAsync() data; resolves classroom IDs to subject names via ClassroomBackendApiService; sorts attempts by recency; added loading and empty states.
- my-certificates-tab.component.html/.css: added empty-state message and loading guard; renders the real subject name and titlecased certificate titles.
- New i18n string I18N_LEARNER_DASHBOARD_MY_CERTIFICATES_EMPTY_STATE (+ qqq description).
Shared component refactor
- Extracted certificate-assessment-titled-shared-background-banner.module.ts so the banner is shared between the player and result pages.
Backend API service
- certificate-assessment-offering-backend-api.service.ts: extended the result response types with certificate_id, time_taken_in_minutes, and topic_name.

Essential Checklist

Please follow the instructions for making a code change.

I have linked the issue that this PR fixes in the "Development" section of the sidebar.
I have checked the "Files Changed" tab and confirmed that the changes are what I want to make.
I have written tests for my code.
The PR title starts with "Fix #bugnum: " or "Fix part of #bugnum: ...", followed by a short, clear summary of the changes.
I have assigned the correct reviewers to this PR (or will leave a comment with the phrase "@{{reviewer_username}} PTAL" if I can't assign them directly).

Proof that changes are correct

Screencast.from.2026-08-12.19-46-58.webm

PR Pointers

Never force push! If you do, your PR will be closed.
To reply to reviewers, follow these instructions: https://github.com/oppia/oppia/wiki/Make-a-pull-request#step-5-address-review-comments-until-all-reviewers-approve
Some e2e tests are flaky, and can fail for reasons unrelated to your PR. We are working on fixing this, but in the meantime, if you need to restart the tests, please check the "If your build fails" wiki page.
See the Code Owner's wiki page for what code owners will expect.

…sult handler

… total_score

…ppia#27004 (oppia#27090) * flake fixes * updated few more troublesome tests * updated few more troublesome tests

…ate-blog-post-and-get-blocked.spec.ts (oppia#27097) * testing * updated dev snap

…TML templates removing inconsistency of next 20 files (part-8) (oppia#27074) Fix part of 25941:Clean up legacy embedded <style> tags from HTML templates (part-8) Co-authored-by: Mohak51234 <143473709+Mohak51234@users.noreply.github.com>

… to support MatBottomSheet (oppia#26914) * Fix part of oppia#26597: Migrate Group 1 base and confirmation modals to support MatBottomSheet * Add bottom-sheet coverage tests for Group 1 modals * Add save and cancel coverage tests for rte-helper bottom-sheet mode * Add math-path save coverage test for rte-helper bottom-sheet mode * Add math-path save coverage tests for rte-helper bottom-sheet mode * Trigger CI * Re-trigger CI --------- Co-authored-by: NITISH KUMAR <imnitishkumar04@gmail.com> Co-authored-by: Mohak51234 <143473709+Mohak51234@users.noreply.github.com>

Update the volunteer page CTA buttons to redirect to the Oppia Idealist page instead of the volunteer form, which has been deactivated. Change the button text to 'Explore Volunteer Openings', update the footer text, and remove the volunteer form link constant and its unused test constants. Rename the e2e selectors to match the new button behavior, and delete the outdated volunteer page screenshots.

…gation

…age. (oppia#27116) * Fix volunteer page CTA buttons to redirect to the Oppia Idealist page Update the volunteer page CTA buttons to redirect to the Oppia Idealist page instead of the volunteer form, which has been deactivated. Change the button text to 'Explore Volunteer Openings', update the footer text, and remove the volunteer form link constant and its unused test constants. Rename the e2e selectors to match the new button behavior, and delete the outdated volunteer page screenshots. * Updated snapshots * Update volunteer acceptance test description to reflect Idealist navigation * Rename volunteer link fields to be destination-specific --------- Co-authored-by: mosin74 <mosin74@gmail.com>

brianrodri · 2026-08-15T10:52:07Z

    </div>
-    <span class="topic-row-value">{{ topic.scorePercentage }}%</span>
+    <span class="topic-row-value">
+      {{ topic.scorePercentage }}%


To get rid of decimal points:

Suggested change

{{ topic.scorePercentage }}%

{{ topic.scorePercentage | number: "1.0-0" }}%

brianrodri · 2026-08-15T10:54:15Z

+        this.isLoading = false;
+      })
+      .catch(() => {
+        this.isLoading = false;


Let's use .finally to make the intent here clearer:

Suggested change

this.isLoading = false;

})

.catch(() => {

this.isLoading = false;

.finally(() => {

this.isLoading = false;

brianrodri · 2026-08-15T10:55:26Z

+    if (totalRelatedQuestions === 0) {
+      return 0;
+    }
+    return Math.round((totalCorrectQuestions / totalRelatedQuestions) * 100);


I think it's OK to return the raw division result, the HTML should be responsible for fixing rounding errors with the | number pipe.

brianrodri · 2026-08-15T10:56:46Z

+          <td class="subject-cell">{{ getSubjectName(attempt.classroom_id) | titlecase }}</td>
+          <td class="attempt-cell">{{ attempt.attempt_index }}</td>
+          <td class="score-cell" [ngClass]="isPassed(attempt) ? 'is-passed' : 'is-not-passed'">
+            {{ attempt.total_score }}%


Suggested change

{{ attempt.total_score }}%

{{ attempt.total_score | number "1.0-0" }}%

brianrodri · 2026-08-15T10:57:15Z

+      .then(() => {
+        this.isLoading = false;
+      })
+      .catch(() => {
+        this.isLoading = false;


Ditto, use .finally() instead to communicate intent.

) * Fix oppia#15185: Add translation progress bar to review tab Wires the existing progress-bar props from the translate tab (added in oppia#15182) into the reviewable translations opportunity list, so reviewers can see per-lesson translation status (cards accepted / in review / available) before opening a lesson to review. * Address review: keep review-tab button enabled when complete The Review Translations tab reuses the same opportunities-list-item progress bar as the Translate Text tab, which was disabling the opportunity button once translationsCount + inReviewCount reached totalCount. On the translate tab that's correct (nothing left to translate), but on the review tab it hid the ability to open a lesson that still has cards pending review. Add a disableButtonOnComplete input (default true, so the translate tab is unaffected) and set it to false for the review tab. * Retrigger CI after transient pip bootstrap failure The previous CI run failed across all jobs (Backend, Lint, Type, Frontend, Full-stack) at the same environment-setup step with: ImportError: cannot import name 'BuildDependencyInstallError' from 'pip._internal.exceptions'. This is a transient GitHub Actions runner/pip issue unrelated to this PR's changes (confirmed by a successful develop-branch Backend unit tests run at the same time). * Retrigger CI: re-run flaky acceptance test (unrelated to PR changes) --------- Co-authored-by: Rohan Unbeg <rohanunbeg0918@gmail.com> Co-authored-by: NITISH KUMAR <imnitishkumar04@gmail.com>

oppia#25268) * prettier fix * linter fix * lo.13 tests * lc.1 tests * IP1 remainder testing * error resolution * error fixing * as previous * debugging * error fixing for card selections * finalizing fixes for exploration * logged out learner tests * formatting fixes * formatting * minor fixes * reverting tsconfig issue * reverting tsconfig issue * reverting git ignore * test * fixing req file * . * fix * fix * fix * removing userjourneys.js * removing navigationPromise approach * fixing minor test failure * resolving error * fixing failing mobile test * linter fixes * linter fixes * linter fixes * verifying push * push test * resolving error * linter fix * time difference check * error resolution * fix * error fix * linter fix * error resolution * debugging * resolving dev mode failures * linter fixes * merge conflict res * reverting file * linter fix * merge conflict resolve * restoring root-files-config * adding missing file to rootfilesconfig to resolve ci error * fix * review fixes * resolving discrepencacies with sheet * error resolving * resolving errors after fixing discrepency * view collection error fix * learn about org fix * adding spreadsheet link, update year * mobile fix * same collection card for mobile error * view collection error fix selector * scroll fix * adjust footer wait * exploration creation mobile error fix (uncovering learner area bc of dropdown overlay * prev error fix * making constant for selectors * date update * date update * error fix overlay block * verifying fix * fixing links * link update * creating functions to ensure spec is high-level only * adding selector constants, removing unnecesarry waits * removing unnecesarry wait * added missing descs for card, removed unnecesarry selector * adding constant for selector * replacing unnecesarry tries w direct dom click * reduced role check time * removed unnecesarry wait * making view-a-collection spec high level, shifting funcs to loggedoutuser ts file * edit * making create basic exp higher level * removing duplicate selectors * fixing failing test (ts error, moving func) * small fix * error fix * test * test * linter fix * adding framework label * reverting change * removing unnecesarry change * as prev * creating func for lowlevel code * indent fix * lint fix * syntax error fix * minor fix * linter fix * matching spreadsheet * bold and italic text check * fixing accidental change * lint fix * removing unused files (ModeratorPage, PreferencePage) * fix * wait fix * test * fix * removing unused vars * test * fix * fix * fix * fix * fix * fix * fix test * removed comments * removed set viewport call and collection_name constant * new getTextContent func * reversing change * removing retry, using selector * fix test * linter fix * reverting change * linter fix * removing retry testing in super admin * as prev * as prev * test * reverting change * adding params * testing fix * testing func removal * removing unnecesarry func as suggested * view fix * edit * fix * test * revert failing fix * conditional fix * reverting fix * test * testing storage clear * small fix * fix test * fix test * revert * super admin removal * removing storage clear * removing unneeded role * skipping mobile test * linter fix * linter fix * linter fix * Removed unnecessary changes * Fixing lint * Resolved conflicts * Fixing failing tests --------- Co-authored-by: Mohak <143473709+Mohak51234@users.noreply.github.com>

…pia#26935) refactor opportunity iteration Co-authored-by: NITISH KUMAR <imnitishkumar04@gmail.com>

…empt services test class

…icate history tab (oppia#27080) * [GSoC 2026] Fix part of oppia#24717: Add i18n keys, shared interfaces and CSS-only dropdown arrow to My Certificates tab (oppia#26973) - Localize table headings, filter options and status/subject labels via i18n keys - Consolidate certificate assessment interfaces into a shared domain model file - Replace SVG background-image dropdown arrow with a CSS-only triangle - Increase certificate table heading and content font size to 20px * Fix part of oppia#24717: Use native link and accessible label for certificate status filter in My Certificates tab * Added css import * Fix part of oppia#24717: Merge certificate assessment offering model into certificate-assessment.model * Use constants for certificate attempt status filters * Fix typecheck and import related issues --------- Co-authored-by: mosin74 <mosin74@gmail.com>

…sessment Attempt Services and Handlers for Starting and Submitting Assessments (oppia#26996) * Created stub intent handler and frontend/backend API services with initial GET logic * Add unit tests for handler and async API service call * Create initial service, decorator, and handler * Lint checks * Add docstrings, improve test coverage, and fix failing lint and backend tests * Update docstrings, add test coverage, and fix failing tests * Updated submission flow fixed mypy checks * Updated test and logic * Fixed query * Reverted some changes and fix failing test * Remove CertificateAssessmentAnswer and validate responses before write * Add indexed certificate_id field and use bounded query for next attempt index * Updated docstring * Address review comments in certificate assessment submission flow * Fixed lint checks * Fix submit certificate assessment handler unit tests to mock attempt retrieval service * Fix lint and mypy errors in certificate assessment code * Use attempt_id in certificate question access decorator * Fixed lint checks * Mypy check --------- Co-authored-by: mosin74 <mosin74@gmail.com>

…that grayed-out elements are not clickable, and ensured drag-and-drop functionality is working as expected. (oppia#25190) * Inital setup * Update role name from topic manager to curriculum admin * Inital logic 2 need to remove comments and clean up code more * Except Chapter to be clickable functionality * Fixed some issues in part 3 * Chapter visible on learner dashboard after publishing * Topic manager part implemented * Added unpublish test and try to fix flakyness of future date * Fix Flaky for future date * Added one chapter to mark as ready to publish * Fixing Lint checks * Fixed flaky nature for future publication date * Fixing CI checks * Mobile CI fix track-upcoming-delayed-publish-chapters * Fix CI for track-upcoming-delayed-publish-chapter * Fixing CI for mobile test for both topic and learner * Adding missing e2e tag * Fixing test for track-upcoming-delayed-publish test on cancel model * Fix test for chapter panal * Removed some mobile carousal tag opening * Ready to publish * Renamed test * For mobile view added e2e tag for title in avilable and comming soon part * Fix type check * Added comment for newly created function * Lint checks * Fix checks * Fix lint checks * change play to clickOnElementWithText * Test fix * Address requested changes * Updated snapshots * Removed comment * Lint issues * Lint checks * Added greyed-out card snapshot and renamed Unpublish modal popup snapshot * Rename snap shot name * Add tests for lesson card new label, drag-and-drop in topic manager, and disabled state validation * Lint checks * Lint checks * Change expectChapterToBeClickable to expectChapterToBeNavigable handled changes in logic to check coming soon chapter not navigate and open * Lint check * Added wait for page to fully load so we can check navigation is performed or not * Lint checks * Added comment for flaky * Test fix for bug * In expectt new label check availableChapters * Fix lessoncardtoHaveNewLabel for mobile * Added comments * Combining repatative code * Added comments explaining problem and mentioned issue number for tracking * Lint checks * Fixing failling backend test which failed due to name mismatch in acceptance.json * Created function and added having new lable check * Updated test to add framework name * Run test for taking snapshot of serial-chapter-learner-view * Added Snapshots for track-upcoming test --------- Co-authored-by: mosin74 <mosin74@gmail.com>

…ng (oppia#26991) * Fix oppia#23330: Add users to user groups regardless of username casing * Use a set for normalized username lookups in _check_if_usernames_are_valid * Assert user is not already in the group before adding in casing test * Move assertNotIn pre-check before the group update for clarity --------- Co-authored-by: NITISH KUMAR <imnitishkumar04@gmail.com> Co-authored-by: Mohak51234 <143473709+Mohak51234@users.noreply.github.com>

…and use .finally for loading state

…gs and strict typescript errors

…ent-m2.17

…est assertions

mosin74 and others added 20 commits August 8, 2026 12:03

Add certificate assessment attempt retrieval service and handlers

2f04617

Fixed mypy check added coverage

209efc4

Add test for missing certificate offering in result handler

d892b68

Merge branch 'develop' into learner-asssessment-m2.14

e796e7f

Add topic-level breakdown and time taken to certificate assessment re…

da5b71f

…sult handler

Merge branch 'develop' into learner-assessment-m2.17

60976ad

Fix certificate assessment result banner and render score from stored…

374f9bc

… total_score

Merge branch 'learner-assessment-m2.11' into learner-assessment-m2.17

812895d

Wire My Certificates tab to certificate assessment datastore data

ecb8b02

Fix oppia#27089: Fixes frontend coverage and flake issues caused by o…

ef990e9

…ppia#27004 (oppia#27090) * flake fixes * updated few more troublesome tests * updated few more troublesome tests

Merge branch 'develop' into learner-assessment-m2.17

96daa44

Merge branch 'learner-assessment-m2.11' into learner-assessment-m2.17

30291f0

Fix oppia#26892: Update desktop snapshots for try-to-publish-a-duplic…

a9c7adf

…ate-blog-post-and-get-blocked.spec.ts (oppia#27097) * testing * updated dev snap

Updated snapshots

51ac41f

Update volunteer acceptance test description to reflect Idealist navi…

3abfa0d

…gation

Rename volunteer link fields to be destination-specific

7529efd

brianrodri suggested changes Aug 15, 2026

View reviewed changes

bhuvan-somisetty and others added 9 commits August 15, 2026 17:35

Fix oppia#18670: Fix o.getOpportunitySubheading is not a function (op…

d5bbe2a

…pia#26935) refactor opportunity iteration Co-authored-by: NITISH KUMAR <imnitishkumar04@gmail.com>

Fix certificate assessment result page tests and remove duplicate att…

a3d2dea

…empt services test class

Merge branch 'develop' into learner-assessment-m2.17

36786bb

mosin74 added 7 commits August 16, 2026 21:37

Merge branch 'develop' into learner-assessment-m2.17

d97d177

Fix certificate assessment review feedback: format score percentages …

094223e

…and use .finally for loading state

Fix part of oppia#24717: Address certificate assessment review findin…

75330cc

…gs and strict typescript errors

Merge branch 'fix-volunteer-with-oppia-CTA-link' into learner-assessm…

f45332e

…ent-m2.17

Fix review findings: round timeTaken, format score, remove CSS/aria t…

161a9c8

…est assertions

Removed redundant rounding off

6c8cf0f

Round aria-valuenow to match visible score label

123a90f

mosin74 closed this Aug 20, 2026

Navigation Menu

[GSoC 2026] M2.17 - Fix part of #24717: Wire certificate assessment result page and My Certificates tab to backend data - #3

[GSoC 2026] M2.17 - Fix part of #24717: Wire certificate assessment result page and My Certificates tab to backend data#3
mosin74 wants to merge 36 commits into
learner-assessment-m2.11from
learner-assessment-m2.17

mosin74 commented Aug 13, 2026

Uh oh!

brianrodri Aug 15, 2026

Uh oh!

brianrodri Aug 15, 2026

Uh oh!

brianrodri Aug 15, 2026

Uh oh!

brianrodri Aug 15, 2026

Uh oh!

brianrodri Aug 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

	{{ topic.scorePercentage }}%
	{{ topic.scorePercentage \| number: "1.0-0" }}%

	{{ attempt.total_score }}%
	{{ attempt.total_score \| number "1.0-0" }}%

Conversation

mosin74 commented Aug 13, 2026

Overview

Essential Checklist

Proof that changes are correct

PR Pointers

Uh oh!

brianrodri Aug 15, 2026

Choose a reason for hiding this comment

Uh oh!

brianrodri Aug 15, 2026

Choose a reason for hiding this comment

Uh oh!

brianrodri Aug 15, 2026

Choose a reason for hiding this comment

Uh oh!

brianrodri Aug 15, 2026

Choose a reason for hiding this comment

Uh oh!

brianrodri Aug 15, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants