draft: add keybind to list optional dependencies#49
Open
darukutsu wants to merge 1 commit intomoson-mo:mainfrom
Open
draft: add keybind to list optional dependencies#49darukutsu wants to merge 1 commit intomoson-mo:mainfrom
darukutsu wants to merge 1 commit intomoson-mo:mainfrom
Conversation
2 tasks
Contributor
Author
|
#55 sparkled idea in my head and went to rework current concept and merge with it. It allowed me to shorten code around 30 lines of code (whole function... haven't done overal code cleaning so might be probably even more removal of unnecessary code). Plus another features as (ofc if we want not implemented yet but its easy):
My question is @moson-mo is it better for you to review only code related to "list optional dependencies" here, so I'll cherry-pick only related changes OR i can close this PR and make updates in #55? Because cherry-picking needed changes will result in some duplicate code in both PRs. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

fixes #29 kinda, user is not prompted but can install optdeps manually, with addition of #47 he could select optdeps he wants. Later we could add keybind which would auto-select all optdeps for example
Shift+D.I think code is more cleaner than in #47 since we not storing whole InfoRecord just some parts of it thus smaller size, saves memory. Although we need to add few things to make it work with #47. I will wait for more information on that. I will probably create another branch then and merge multiselect and this together in one pr.
I was thinking about 2 possible reworks:
Demonstration:
https://github.com/user-attachments/assets/c5b98d1d-722c-40e1-9498-54cc096c5ca7