Skip to content

Deduplicate SemanticLabel: remove Human, consolidate to Person - #102

Merged
mosure merged 2 commits into
mainfrom
copilot/fix-duplicate-semantic-labels
Mar 10, 2026
Merged

Deduplicate SemanticLabel: remove Human, consolidate to Person#102
mosure merged 2 commits into
mainfrom
copilot/fix-duplicate-semantic-labels

Conversation

Copilot AI commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

SemanticLabel had two overlapping variants (Human and Person) representing the same concept. Human is removed; "human" string inputs are now remapped to SemanticLabel::Person.

Changes

  • src/render/semantic.rs: Removed Human variant from SemanticLabel enum; dropped its arms from color() and as_str(); mapped "human" in from_label() to SemanticLabel::Person
  • src/scene/semantic_room.rs: Updated human entity spawning to use SemanticLabel::Person
// Before
SemanticLabel::Human  // duplicate variant with same semantic meaning as Person

// After — "human" input strings still parse correctly
SemanticLabel::from_label("human") // => Some(SemanticLabel::Person)

The "human" mesh type name used in ZeroversePrimitives::Mesh("human") (burn_human mesh pipeline) is intentionally unchanged.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: mosure <35904762+mosure@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix duplicate semantic labels for human and person Deduplicate SemanticLabel: remove Human, consolidate to Person Mar 10, 2026
@mosure
mosure marked this pull request as ready for review March 10, 2026 15:10
@mosure
mosure enabled auto-merge (squash) March 10, 2026 15:11
@mosure
mosure disabled auto-merge March 10, 2026 15:20
@mosure
mosure merged commit a6a29ab into main Mar 10, 2026
8 of 11 checks passed
@mosure
mosure deleted the copilot/fix-duplicate-semantic-labels branch March 10, 2026 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants