Deduplicate SemanticLabel: remove Human, consolidate to Person - #102
Merged
Conversation
Co-authored-by: mosure <35904762+mosure@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix duplicate semantic labels for human and person
Deduplicate SemanticLabel: remove Human, consolidate to Person
Mar 10, 2026
mosure
marked this pull request as ready for review
March 10, 2026 15:10
mosure
enabled auto-merge (squash)
March 10, 2026 15:11
mosure
disabled auto-merge
March 10, 2026 15:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SemanticLabelhad two overlapping variants (HumanandPerson) representing the same concept.Humanis removed;"human"string inputs are now remapped toSemanticLabel::Person.Changes
src/render/semantic.rs: RemovedHumanvariant fromSemanticLabelenum; dropped its arms fromcolor()andas_str(); mapped"human"infrom_label()toSemanticLabel::Personsrc/scene/semantic_room.rs: Updated human entity spawning to useSemanticLabel::PersonThe
"human"mesh type name used inZeroversePrimitives::Mesh("human")(burn_human mesh pipeline) is intentionally unchanged.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.