fix: connectivity — DHT log, pairEnterPin, web_url warning, dependency updates#3
Merged
fix: connectivity — DHT log, pairEnterPin, web_url warning, dependency updates#3
Conversation
kad_start_providing now waits for DHT peer confirmation before returning. Update the log message to reflect this: show "Publishing..." while waiting and "confirmed by DHT peers" on success, with actionable error on failure.
Previously saved a random peer ID from pairEnterPin, causing reconnection to fail. Now passes profile.libp2p_peer_id to cairn so the correct host peer ID is stored for future reconnection.
Detects localhost/127.0.0.1 in the web_url config setting and prints a warning explaining the URL won't be reachable from other devices, with guidance to use the default GitHub Pages URL.
Tauri was pinned to cairn-p2p 0.3.0 (commit cb4d293, 6 versions behind). Updated to 0.4.0 (commit 1c043c6) which includes SPAKE2 cross-language alignment, discovery backends, and all prior iteration fixes.
Picks up the 0.6.0 release which includes SPAKE2 alignment fixes and the new pairEnterPin signature with optional remotePeerId parameter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 5 jaunt-side issues from the connectivity investigation report (cairn-side fixes merged in moukrea/cairn#4).
kad_start_providingnow reports actual propagation status ("confirmed by DHT peers" on success, actionable error on failure)profile.libp2p_peer_idtopairEnterPinso the correct host peer ID is stored for reconnection (previously stored random bytes)web_urlconfig points tolocalhost/127.0.0.1Test plan
cargo fmt --checkpassescargo clippy --workspace --all-targets -- -D warningspassescargo test --workspace— 19 tests pass