fix(hook): drop tee capture and use tcgetpgrp for fg process#15
Closed
fix(hook): drop tee capture and use tcgetpgrp for fg process#15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes remaining issues from the hook rework (#14):
Drop tee-based capture:
exec > >(tee -a FILE) 2>&1made stdout a pipe, breakingisatty()— TUI apps (nano, vim) couldn't initialize ncurses properly and keyboard shortcuts failed. The hook now only exportsSNAG_SESSIONwith zero side effects.snag ls/cwd/ps/attach/sendall work via/procand the stolen master fd. Onlysnag outputloses scrollback for hooked sessions.Use
tcgetpgrpfor FG process detection: replaces the/procscan heuristic (which returned ALL processes on the PTY, including backgroundtee) withnix::unistd::tcgetpgrp(master_fd)— the kernel's authoritative answer for the foreground process group. Showsidleat the prompt, the actual command name when running something.