fix: Normalization and factor conversion fixes#156
Open
Conversation
…n daily checks on macos-latest
- M1: Fix percent UOM label inconsistency - use grepl() instead of
exact equality to match percentage patterns consistently
- M10: Replace hardcoded column indices with named column access
in legacy column file support
Note: M2 (handle missing attrs in normalize_cansim_values) deferred
to a separate PR as it requires more investigation - the naive fix
caused unintended metadata folding in vector flows.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issues with normalization and factor conversion.
Changes
M1: Percent UOM label inconsistency
uom_string == percentage_stringtogrepl(percentage_string, uom_string)percentage_stringis a regex pattern (^Percent), so exact equality was never matchingM10: Hardcoded column indices in legacy support
meta2[,1]andmeta2[,2]with named column accessmeta2[[dimension_name_col]]andmeta2[..., dimension_id_col]Deferred
M2: Handle missing attrs in normalize_cansim_values
cansimTableNumberfrom data columns caused unintended metadata folding in vector flowsTest plan
devtools::check()passes with 0 errors, 0 warningsRelated Issues
Addresses #147 (Normalization and factor conversion bugs) - partially
🤖 Generated with Claude Code