Optimize get_cansim_table_template() with expand_grid#163
Open
mountainMath wants to merge 1 commit intov0.4.5from
Open
Optimize get_cansim_table_template() with expand_grid#163mountainMath wants to merge 1 commit intov0.4.5from
mountainMath wants to merge 1 commit intov0.4.5from
Conversation
Replace iterative full_join with tidyr::expand_grid for Cartesian product: - Old: Sequential full_join operations, updating COORDINATE after each join - New: Single expand_grid call, vectorized paste for COORDINATE Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Optimize
get_cansim_table_template()by replacing iterativefull_joinoperations with a singletidyr::expand_grid()call.Before (iterative approach)
After (vectorized approach)
Benchmark Results
Tested with installed package versions (mean of 5 runs each):
Correctness Verification
Output verified identical to original on all test tables:
Test Plan
devtools::test()- 20 tests)🤖 Generated with Claude Code