deps: relax pydantic pin to >=2.9.2 (unblock modern mcp/fastmcp) - #49
Merged
Conversation
The exact pydantic==2.9.2 pin blocked any consumer needing pydantic>=2.11 — notably modern mcp/fastmcp, whose Tool.from_function needs pydantic>=2.11 to handle PEP 604 (str | None) tool annotations. Relaxing to >=2.9.2 lets those consumers resolve while keeping 2.9.2 as the floor. pydantic-settings stays hard-pinned at 2.6.1: 2.14.x regresses env_prefix + dotenv handling (test_init_file_prefix1 — file-sourced values return None). Full settings suite: 441 passed on pydantic 2.13.4 + pydantic-settings 2.6.1. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Member
Author
|
S1 coordinated PR set (torch-free embedding + semantic e2e):
Merge order: settings #49 → core #52 + lookup #2 (together — shared build↔query contract) → mcp #3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Relax
pydantic==2.9.2→pydantic>=2.9.2in mountainash-settings. Keeppydantic-settings==2.6.1.Why
The exact
pydantic==2.9.2pin transitively blocked every consumer that needs pydantic>=2.11. Concretely, modern mcp/fastmcp (Tool.from_function) needs pydantic>=2.11 to handle PEP 604str | Nonetool parameter annotations; on the old pin the resolver backtracked mcp to 1.12.4, whose fastmcp raisesTypeError: issubclass() arg 1 must be a classon union annotations. This surfaced building themountainash-pointbreak-mcpsemantic-search integration env.Safety
pydantic-settings is kept at 2.6.1 because 2.14.x regresses this package's env_prefix + dotenv handling (
test_init_file_prefix1: file-sourced values returnNone). Confirmed by bisection: the test passes on 2.6.1, fails on 2.14.2.Full settings test suite on the combo this pin resolves to (pydantic 2.13.4 + pydantic-settings 2.6.1): 441 passed.
🤖 Generated with Claude Code