fix(relations): gate against authoritative input dialect, not anchor (item 95) - #285
Merged
Merged
Conversation
…(item 95) _gate_capabilities now keys its dialect-scoped lookup off the operation's authoritative (first/left) input operand's dialect, resolved recursively, instead of the visitor's single anchor dialect. - _UNRESOLVED sentinel + _first_input_node exhaustive dispatch - _physical_identity (recursive left-authoritative, cycle-guarded, fail-safe) - _authoritative_dialect -> sentinel | str | None - identity_resolver visitor param; DAG supplies name->root-node closure - item-91 gating test inverted to the operand-aware semantics Design: mountainash-central 2026-08-14-multi-input-node-anchor-dialect-gating.md (Rev 5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements backlog item 95 — multi-input node capability gating uses the authoritative (first/left) input operand's dialect.
_gate_capabilitiespreviously keyed its dialect-scoped lookup off the visitor's single anchor dialect, so a dialect-scopedGATEfact on an inline operand fired against the wrong string. It now resolves the authoritative input dialect recursively.Changes
_UNRESOLVEDsentinel +_first_input_node(exhaustive dispatch, fail-safe)_physical_identity(recursive left-authoritative, cycle-guarded, fail-safe)_authoritative_dialect(node, op)→_UNRESOLVED | str | Noneidentity_resolvervisitor param; DAG wiresname → relations[name]._nodeTestGatingUsesAnchorDialectNotTrueLeftOperandDialectto the operand-aware semanticsTests:
tests/relations/test_rel_authoritative_dialect_gating.py(inline-operand gate, non-firing left-matches-anchor, join-gate-on-left, unbound-Ibis→None, cycle protection, empty-set).Full suite: 22252 passed, 0 failed. Ruff clean. (mypy baseline has pre-existing
import-untyped/capability_census errors, unchanged.)Design: mountainash-central
2026-08-14-multi-input-node-anchor-dialect-gating.md(Revision 5).