feat(relations): Relation.sample(seed=) with validation sampling - #298
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…REL-03 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Relation.sample(n=, fraction=, seed=)contract andInvalidSampleArgumentsError.seedthrough the public protocol, Mountainash backend protocol, and Polars/Narwhals/Ibis implementations.n; support Narwhals lazy sampling through collect/sample/re-lazy; preserve Ibis Bernoulli semantics with strict xfails for ibis-polars and ibis-sqlite seed limitations.Validator._sliceon the execution backend, pin implicit seeds, record the effective fallback seed, and record a closed-by-default fallback when a non-empty input samples to zero rows.regex_contains, fixing false passes on Narwhals and ibis-duckdb.NW-REL-03divergence fact and generated census/docs entries.Verification
74 passed, 6 xfailedfor the post-review validator/sample/capability checks.441 passed, 4 skipped, 14 xfailed.23051 passed, 81 skipped, 1 unrelated strict XPASS, 3469 xfailed.IB-DT-13onibis-sqliteintest_show_recent_errors; it is reproducible and filed as mountainash-central backlog item 105, not changed by this PR.Spec: mountainash-central
04.planning/mountainash/superpowers/specs/2026-08-17-syntheticdata-validation-roundtrip-design.md.Part B is independent of this PR and of item 8j PR #297.