chore(registry): document IB-DT-19's shipped workaround (item 112, PR #303) - #304
Merged
Merged
Conversation
…303) PR #302 (adding this entry) and PR #303 (shipping the fix) merged in the opposite order (303 landed first), leaving our_workaround: none stale on develop even though ensure_sqlite_nat_adapter() already shipped in the same history. Update our_workaround to fallback_impl and document the shim, its call sites, the rejected alternatives, and the xfail(strict=True) upstream-fix monitor that will flag when ibis fixes this natively. Verified: scripts/validate_upstream_registry.py passes (127 entries, 0 errors); tests/core/test_upstream_registry_join.py and tests/scripts/test_validate_upstream_registry.py pass (25 passed).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #302 (adding the IB-DT-19 registry entry) and PR #303 (item 112, shipping the actual
ensure_sqlite_nat_adapter()fix) merged out of order — #303 landed first, then #302 — leavingour_workaround: nonestale ondevelopeven though the real workaround already existed in the same history by the time both merged.This updates the entry:
our_workaround: none→fallback_impl(mountainash implements its own workaround, perVALID_WORKAROUNDSschema)notes: documents the shipped shim (_sqlite_compat.py::ensure_sqlite_nat_adapter), its 3 production + 4 test-fixture call sites, the rejected alternatives (explicit-schema/pandas.to_sql), and thexfail(strict=True)upstream-fix monitor that will flag CI the moment ibis fixes this nativelylast_verifiedbumped to2026-08-19mountainash-data's own DEBT-13 (a separate, unshipped fix in that repo) remains independent — this workaround only covers mountainash's own memtable-construction call sitesNo code changes.
statusstaysneeds_filing(the upstream issue itself is drafted, not filed, per explicit instruction on PR #303).Verification